[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-octave-devel] Bug#756704: marked as done (dynare: [hdf5 transition] please support hdf5 1.8.13 new packaging layout)

Your message dated Sun, 31 Aug 2014 09:23:03 +0200
with message-id <1409469783.26573.5.camel@debian.org>
and subject line Re: dynare: [hdf5 transition] please support hdf5 1.8.13 new packaging layout
has caused the Debian Bug report #756704,
regarding dynare: [hdf5 transition] please support hdf5 1.8.13 new packaging layout
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
756704: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756704
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: dynare
Version: 4.4.2-2
Severity: important
Tags: patch
User: pini@debian.org
Usertags: HDF5-transition

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

The hdf5 1.8.13 package in experimental features a new layout for
headers and libraries, so that all the binary packages are now
co-installable.

Please find attached a patch proposal to support both the current
and the new layouts.

Because this bug is in the way of the hdf5 transition I intend to NMU
in a few days. I apologize for the urge, and I hope this approach won't
offend you. Please tell me otherwise.

Kind regards,

_g.

- -- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.14-1-486
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJT2smUAAoJEO/obGx//s+D7Q0IAJhap5BdDsIKqGlSiEd32P5K
aScHDSoZfCgfn331oW56Jf2UEYghhqYujMPPPqr/ofigxv/1+Iu9P6olkwJxDTjS
EDEtEnJOSeoLwEf5xSdheQIcr+zHM6UjZ3T6/rU07to/MQpae2W5zFxXrRjBz9Zm
eJbg/FLSfymVEXrLBX2Rr6GOSyAb/I2zekWQvfoSGTkGHZUzkv1+vK5CKIG4B+6t
nh4f/lbIIfWvgWiB8i+MMuUC87HVKoIPc/8CjFEaJHSNv1GkYd+EDSw0JL2NcT9r
YiFImEvRcKo4h3bWmpecJaCNOj68eaO7JDOnrkw5lXMDQvtcww0DwXKAXCDn7uA=
=NF5y
-----END PGP SIGNATURE-----

diff -Nru dynare-4.4.2/debian/changelog dynare-4.4.2/debian/changelog
--- dynare-4.4.2/debian/changelog	2014-03-24 17:41:45.000000000 +0100
+++ dynare-4.4.2/debian/changelog	2014-07-27 22:13:48.000000000 +0200
@@ -1,3 +1,10 @@
+dynare (4.4.2-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Support hdf5 1.8.13 new packaging layout.
+
+ -- Gilles Filippini <pini@debian.org>  Sun, 27 Jul 2014 22:13:48 +0200
+
 dynare (4.4.2-2) unstable; urgency=medium
 
   * dynare-matlab: add missing dependency on libmatio-dev. (Closes: #742259)
diff -Nru dynare-4.4.2/debian/rules dynare-4.4.2/debian/rules
--- dynare-4.4.2/debian/rules	2013-12-16 16:25:05.000000000 +0100
+++ dynare-4.4.2/debian/rules	2014-07-31 19:15:16.000000000 +0200
@@ -2,6 +2,10 @@
 
 include /usr/share/octave/debian/defs.make
 
+ifneq ($(wildcard /usr/lib/$(DEB_HOST_MULTIARCH)/hdf5/serial/libhdf5.so),)
+  export DEB_CPPFLAGS_MAINT_APPEND := -I/usr/include/hdf5/serial
+endif
+
 %:
 	dh $@ --parallel --with autoreconf

--- End Message ---
--- Begin Message --- 
Le vendredi 29 août 2014 à 01:42 +0200, Gilles Filippini a écrit :

> Sébastien Villemot a écrit , Le 14/08/2014 16:00:
> > Le mardi 05 août 2014 à 15:15 +0200, Sébastien Villemot a écrit :
> >> Le vendredi 01 août 2014 à 00:56 +0200, Gilles Filippini a écrit :
> >>> Source: dynare
> >>> Version: 4.4.2-2
> >>> Severity: important
> >>> Tags: patch
> >>> User: pini@debian.org
> >>> Usertags: HDF5-transition
> >>
> >>> The hdf5 1.8.13 package in experimental features a new layout for
> >>> headers and libraries, so that all the binary packages are now
> >>> co-installable.
> >>>
> >>> Please find attached a patch proposal to support both the current
> >>> and the new layouts.
> >>>
> >>> Because this bug is in the way of the hdf5 transition I intend to NMU
> >>> in a few days. I apologize for the urge, and I hope this approach won't
> >>> offend you. Please tell me otherwise.
> >>
> >> I don't think that this NMU is needed. At the place where the build
> >> fails with the new HDF5, dynare takes its CPPFLAGS from mkoctfile (from
> >> package octave). So once octave is adapted for the new HDF5, this bug
> >> should be automatically fixed (unless there is a second issue at another
> >> place). I'm therefore marking this bug as being blocked by the one in
> >> octave.
> > 
> > I confirm that, with #756689 fixed, the Dynare source package is ready
> > for the HDF5 transition. So I'm closing this bug.
> > 
> > Note that, when the transition starts, octave will have to be binNMUed
> > and recompiled on all archs before dynare can be binNMUed.
> 
> The binNMUs are successful but dynare lose HDF5 support then. The build
> logs have:
>  checking for H5Fcreate in -lhdf5... no
> where it used to have:
>  checking for H5Fcreate in -lhdf5... yes
> 
> This is because of the m4 macro m4/ax_matio.m4 which doesn't rely on
> pkg-config.
> 
> I'm then re-opening this bug and attaching a patch proposal.
> 
> Feel free to close it again in case you're fine with the current binNMUs.

Thanks for your feedback. Actually Dynare does not use HDF5 directly,
but only through MatIO: the test that you mention is only useful for
linking with MatIO on platforms where dynamic linking is not available.
Future versions of Dynare should use pkg-config for that purpose, which
is much better.

I'm closing this bug, since it is has no practical consequences.

-- 
 .''`.    Sébastien Villemot
: :' :    Debian Developer
`. `'     http://www.dynare.org/sebastien
  `-      GPG Key: 4096R/381A7594

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: