[Pkg-octave-devel] [RFU] octave-dataframe 1.0.0-1
I prepared version 1.0.0-1 of octave-dataframe in Git. Please upload
it.
You will note that one of the tests fails:
[@dataframe/private/strsplit]
***** assert (strsplit ("road to^hell", " ^"), {"road", "to", "hell"})
!!!!! test failed
ASSERT errors for: assert (strsplit ("road to^hell", " ^"),{"road", "to", "hell"})
This happens because the version of strsplit shipped with the octave
package is used in the test, instead of the private one. An old version
of the strsplit.m file has been introduced in the dataframe package on
purpose, in order to insure compatibility.
I think that it makes no sense to include test chunks into a private
function or, at least, to exercise them. We might change the check-pkg
target in octave-pkg.mk in order to avoid it. Tell me if you agree and I
will make the change.
Another issue with this package is that the globally-declared license
(GPLv3+) does not correspond to the licensing statements in the *.m files
(GPLv2+). I already filed a bug report upstream about this [1], but I do
not think that this would prevent its upload to unstable. Note that the
per-file license is reported in debian/copyright.
Rafael
1. https://savannah.gnu.org/bugs/index.php?42053
Reply to: