[Pkg-octave-devel] Bug#706376: Bug#706376: Bug#706376: Bug#706376: Bug#706376: Bug#706376: Bug#706376: Bug#706376: octave: sparse matrix n*2^16
On 20 June 2013 10:41, David Bateman <adb014@gmail.com> wrote:
>
>
> Le 20 juin 2013 à 15:01, "John W. Eaton" <jwe@octave.org> a écrit :
>
>> On 06/19/2013 08:32 PM, David Bateman wrote:
>>>
>>> Ok, it seems Jaroslav's code for idx_vector(Sparse<bool> hasn't been
>>> used much in the last 5 years as it was completely wrong and when I
>>> started using it, it caused 791 failures in "make check". I've fixed his
>>> code as it makes sense to use it and pushed my changeset at
>>>
>>> http://hg.savannah.gnu.org/hgweb/octave/rev/8fce0ed4894a
>>
>> This change seems OK to me, but is there some reason to not use
>>
>> dim_vector dv = dims ();
>> return (dv.any_zero ());
>>
>> as the default definition for is_empty?
>
> Just the principal of minimum impact on existing code.
I prefer the principle of consistency and as few special cases as
possible. More special cases increase code complexity and makes it
more difficult to maintain.
- Jordi G. H.
Reply to: