[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-octave-devel] Bug#678893: Bug#678893: octave-pkg-dev: Use generated PKG_ADD/PKG_DEL files at build time



Le dimanche 24 juin 2012 à 23:49 +0200, Thomas Weber a écrit :
> Package: octave-pkg-dev
> Version: 1.0.2
> Severity: wishlist
> 
> The current code only handles PKG_ADD files that come with the upstream
> tarball. It is however valid to generate those files at build time, so
> we should cope with that.
> 
> The 'find' command in octave-sockets could be used to get a better
> command in octave-pkg-dev.

My understanding is that octave-pkg-dev already uses the PKG_ADD created
at build time. Indeed, the following command in octave-pkg.mk adds all
paths under debian/octave-XXX/:

  addpath (genpath ([pwd()], '.pc'))

And Octave loads every PKG_ADD located in a path added with addpath.

So I think there is nothing to do.

Moreover, the following lines in octave-pkg.mk seem redundant and could
be deleted:

	if [ -f PKG_ADD ] ; then				\
		echo "source('PKG_ADD');" >> $$tmp ; 		\
	fi ;							\
	if [ -f PKG_ADD.bak ] ; then				\
		echo "source('PKG_ADD.bak');" >> $$tmp ;	\
	fi ;	

-- 
 .''`.    Sébastien Villemot
: :' :    Debian Developer
`. `'     http://www.dynare.org/sebastien
  `-      GPG Key: 4096R/381A7594

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: