Rafael Laboissiere <rafael@laboissiere.net> writes: > * Sébastien Villemot <sebastien.villemot@ens.fr> [2012-05-13 14:59]: > >> When the testsuite of an Octave Forge package is run, the unit tests of files >> under inst/private are not run (instead one gets a non-fatal error message). >> >> Example from octave-statistics, which contains a file called >> inst/private/tbl_delim.m: >> >> [tbl_delim] >> ????? tbl_delim does not exist in path >> >> The error message is harmless, but as a consequence the unit tests of >> tbl_delim.m are not run. > > For the normal usage of Octave, having tests burried into private files > is a design mistake, since they cannot be exercised by the test() > function. Of course, one can add the private directory to the path, but > this would defeat the very concept of a "private" directory. I had not realized that it was indeed a design mistake. Given that, it probably makes sense to choose your option (2) below: > (2) We inform the upstream author about the design mistake. In the case > of tbl_delim.m in octave-statistics, in particular, the tests were kept > when the file moved from inst/__tbl_delim__.m into > inst/private/tbl_delim.m [*]. A rational thing to do would be to move > the tests from tbl_delim.m into tblwrite.m, the only place where > tbl_delim() is invoked. I know that other packages besides statistics are affected. We need to identify them and report the issues upstream. -- Sébastien Villemot Researcher in Economics & Debian Maintainer http://www.dynare.org/sebastien Phone: +33-1-40-77-84-04 - GPG Key: 4096R/381A7594
Attachment:
pgpk41YL_iTx4.pgp
Description: PGP signature