[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-octave-devel] octave-missing-functions buggy



* Thomas Weber <tweber@debian.org> [2012-03-13 21:53]:

> as far as I can see, octave-missing-functions tries to access a
> Mathworks site in order to get the list of functions in Matlab.
> Well, that site returns a 404 and the package has no maintainer.
> 
> Any objections to removing it?

The patch to make it work is quite trivial (attached below).  However, if
the package is really not maintained upstream, it should be better to
drop it.

Rafael
--- octave-missing-functions-1.0.2.orig/inst/__matlabfunctionlist__.m
+++ octave-missing-functions-1.0.2/inst/__matlabfunctionlist__.m
@@ -24,7 +24,7 @@
 ## may not be sorted or unique.
 ## @end deftypefn
 
-function [funlist, funloc, catlist, catloc, catlvl] = __matlabfunctionlist__ (url = "http://www.mathworks.com/access/helpdesk/help/techdoc/ref/f16-6011.html";)
+function [funlist, funloc, catlist, catloc, catlvl] = __matlabfunctionlist__ (url = "http://www.mathworks.com/help/techdoc/ref/f16-6011.html";)
 
   [raw, success, message] = urlread(url);
   if (! success)
@@ -71,7 +71,7 @@ function [funlist, funloc, catlist, catl
     ## convert all whitespace to actual spaces
     tmpfunname(isspace (tmpfunname)) = " ";
     if (numel (tmpfunname) > 2)
-      tmpfunname = split (tmpfunname, ", ");
+      tmpfunname = strsplit (tmpfunname, ", ");
     endif
     for j = 1:rows (tmpfunname)
       idx++;
--- octave-missing-functions-1.0.2.orig/inst/missingmatlabfunctions.m
+++ octave-missing-functions-1.0.2/inst/missingmatlabfunctions.m
@@ -22,7 +22,7 @@
 ## @seealso{missingfunctionstatus}
 ## @end deftypefn
 
-function missingmatlabfunctions (outfile = "", outformat = "", url = "http://www.mathworks.com/access/helpdesk/help/techdoc/ref/f16-6011.html";)
+function missingmatlabfunctions (outfile = "", outformat = "", url = "http://www.mathworks.com/help/techdoc/ref/f16-6011.html";)
 
   [funlist, funloc, catlist, catloc, catlvl] = __matlabfunctionlist__ (url);
   funstat = __functionstatus__ (funlist);
--- octave-missing-functions-1.0.2.orig/inst/missingfunctionstatus.m
+++ octave-missing-functions-1.0.2/inst/missingfunctionstatus.m
@@ -23,7 +23,7 @@
 
 function missingfunctionstatus (outdir = ".")
 
-  urlbase = "http://www.mathworks.com/access/helpdesk/help/";;
+  urlbase = "http://www.mathworks.com/help/";;
 
   toolboxes = {"Matlab" "techdoc/ref/f16-6011.html";
                "Aerospace" "toolbox/aerotbx/ug/bqj21qj.html";

Reply to: