[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-octave-devel] Packaging octplot



[Shai: for the context of this message, please see:
http://lists.alioth.debian.org/pipermail/pkg-octave-devel/2005-December/000850.html
]

* Rafael Laboissiere <rafael@debian.org> [2005-12-04 05:19]:

> 3) No-reentrancy: once the package has been build for the first time, it
>    fails to build again yielding the following error message:
>    
>        chmod a+x /root/octplot/octplot-0.3.0/./configure
>        chmod: cannot access `/root/octplot/octplot-0.3.0/./configure': No such file or directory
> 
>    This is totally reproducible here.  Is it the same for you?

I think I fixed this with my last SVN commit.  This is a serious problem
with the upstream sources, so that I am Ccing this message to Shai Ayal.
The topdir Makefile is wrongly defining the distclean target like this:

distclean: clean
	rm -f *~
	rm -f configure Makefile.in

According to section 7.2.5 "Standard Targets for Users" of the GNU
Coding Standards
(http://www.gnu.org/prep/standards/standards.html#Standard-Targets), the
distclean target should not delete the configure script neither the
Makefile.in file.  Indeed:

    `distclean'
           Delete all files in the current directory (or created by this
           makefile) that are created by configuring or building the
           program. If you have unpacked the source and built the program
           without creating any other files, `make distclean' should
           leave only the files that were in the distribution. However,
           there is no need to delete parent directories that were
           created with `mkdir -p', since they could have existed anyway.

Besides, since the octplot configuration uses Automake, there is no need
to redeclare the distclean target, since that tool takes care of it.  
For getting the "*~" removed, without declaring the distclean target,
here is the trivial patch:


--- Makefile.am	2005-11-23 18:14:06.000000000 +0100
+++ Makefile.am-new	2005-12-05 23:18:45.552212928 +0100
@@ -11,6 +11,4 @@
 EXTRA_DIST = ReleaseNotes.txt README.linux README.cygwin README.mac README
 SUBDIRS = fonts src demos
 
-distclean: clean
-	rm -f *~
-	rm -f configure Makefile.in
+CLEANFILES =  *~


Notice that the solution I implemented for the Debian package was to
patch the Makefile.in file instead.  Had I patched Makefile.am, we would
have to run automake in the package building.  I hope Shai will cope with
this issue in the next release of octplot.

Please, take a look at the current status of the package.  If it is okay
for you, I will soon fill the ITP bug report.

-- 
Rafael



Reply to: