Bug#1073882: FTBFS with OCaml 5.2.0 (Needs porting)

[Stéphane Glondu <glondu@debian.org>]

Hi Bo,

Le 15/10/2024 à 04:35, Bo YU a écrit :
> Given upstream's help, the package can be built on my local build now,
> see:
> https://github.com/jrh13/hol-light/issues/101#issuecomment-2411453740

Great to hear!

> But there are two issues blocks me to upload:
>
> 1. there is no doc which hits how to exclude files likes this[0]
> descripted
>
> [0]: https://salsa.debian.org/ocaml-team/hol-light/-/blob/master/debian/ 
> hol-light-source.exclude?ref_type=heads

I don't understand your question...

> 2. we will have to modify the d/rules to pass the build and this will
> change the results of built:
>
> ```
> --- a/debian/rules
> +++ b/debian/rules
> @@ -29,8 +29,8 @@ override_dh_auto_clean:
>
>   .PHONY: override_dh_auto_build
>   override_dh_auto_build:
> -       dh_auto_build
> -       ocamlfind ocamlmktop -verbose -package compiler-libs -package 
> camlp-streams -linkpkg -o ocaml
> +       $(MAKE)
> +       #ocamlfind ocamlmktop -verbose -package compiler-libs -package 
> camlp-streams -linkpkg -o ocaml
>
> @@ -41,7 +41,7 @@ override_dh_auto_install:
>          chmod -x $(INSTDIR)/usr/share/hol-light/*.ml
>          chmod -x $(INSTDIR)/usr/share/hol-light/*/*.ml
>          install -d $(INSTDIR)/usr/bin
> -       install ocaml $(INSTDIR)/usr/share/hol-light
> +       #install ocaml $(INSTDIR)/usr/share/hol-light
>          install debian/hol-light.sh $(INSTDIR)/usr/bin/hol-light
> ```
>
> Obviously this may affect the functionality of the package.

Why?

Given the way hol-light works (last time I looked), I think an 
autopkgtest would be ideal.

Also, please do not leave commented lines if they are not meant to come 
back.


Cheers,

--
Stéphane