[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#977179: marked as done (mlpost: reproducible builds: Embeds build time in various binaries)

Your message dated Thu, 15 Dec 2022 09:21:44 -0800
with message-id <875yecinvb.fsf@contorta>
and subject line Re: mlpost: reproducible builds issues fixed in newer version
has caused the Debian Bug report #977179,
regarding mlpost: reproducible builds: Embeds build time in various binaries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
977179: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977179
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: mlpost
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Various binaries in mlpost contain timestamps from the running build:

  https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/mlpost.html

  /usr/lib/ocaml/mlpost/mlpost.a
  120 Sun·Jan··9·20:01:41·-12·2022	120 Tue·Dec··8·15:41:43·+14·2020


The attached patch fixes this by passing options to the call to date in
configure.in to use the SOURCE_DATE_EPOCH environment variable:

  https://reproducible-builds.org/docs/source-date-epoch/


Thanks for maintaining mlpost!


live well,
  vagrant

From 9dac79dbe61945338a2c2a51f4f43d88b9dae464 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 12 Dec 2020 05:49:48 +0000
Subject: [PATCH 1/2] Patch configure.in to use SOURCE_DATE_EPOCH for the date.

This patch relies on GNU extensions to date and may need further
adjustments to be made portable.

https://reproducible-builds.org/docs/source-date-epoch/
---
 configure.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.in b/configure.in
index 5b47867..09078e7 100644
--- a/configure.in
+++ b/configure.in
@@ -34,7 +34,7 @@
 AC_INIT(mlpost,0.8.2,[],[],[])
 
 # The compilation date
-TODAY=`date`
+TODAY=`LC_ALL=C date --utc --date=@${SOURCE_DATE_EPOCH}`
 
 # Check for Ocaml compilers
 
-- 
2.29.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Version: 0.9-1

Both the timestamp and tarball issues appear to have been fixed for
about a year in bookworm/testing:

  https://tests.reproducible-builds.org/debian/history/mlpost.html

There are some build path issues still present in unstable, but neither
of these patches addressed those issues.


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: