Bug#984261: ocaml-mccs: ftbfs with GCC-11

[Matthias Klose <doko@debian.org>]

Package: src:ocaml-mccs
Version: 1.1+11-1
Severity: normal
Tags: sid bookworm
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/ocaml-mccs_1.1+11-1_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
dpkg-source: info: unpacking ocaml-mccs_1.1+11.orig.tar.xz
dpkg-source: info: unpacking ocaml-mccs_1.1+11-1.debian.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 0001-lp_solver.cpp-Fix-typos.patch

Check disk space
----------------

Sufficient free space for build

User Environment
----------------

APT_CONFIG=/var/lib/sbuild/apt.conf
HOME=/sbuild-nonexistent
LANG=C.UTF-8
LC_ALL=C.UTF-8
LOGNAME=user42
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
SCHROOT_ALIAS_NAME=unstable
SCHROOT_CHROOT_NAME=sid-amd64-sbuild
SCHROOT_COMMAND=env
SCHROOT_GID=1001
SCHROOT_GROUP=user42
SCHROOT_SESSION_ID=sid-amd64-sbuild-cfdb0ec1-7d7b-40f0-9974-60d078ad5bdf
SCHROOT_UID=1001
SCHROOT_USER=user42
SHELL=/bin/sh
USER=user42

dpkg-buildpackage
-----------------

Command: dpkg-buildpackage -us -uc -b -rfakeroot
dpkg-buildpackage: info: source package ocaml-mccs
dpkg-buildpackage: info: source version 1.1+11-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Nicolas Braud-Santoni <nicoo@debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 debian/rules clean
dh clean --with ocaml
   dh_ocamlclean
   dh_clean
 debian/rules binary
dh binary --with ocaml
   dh_update_autotools_config
   dh_autoreconf
   dh_ocamlinit
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
mv src/glpk/dune-shared src/glpk/dune
dune build -p mccs
x86_64-linux-gnu-gcc src/mccs_stubs.o (exit 1)
(cd _build/default/src && /usr/bin/x86_64-linux-gnu-gcc -O2 -fno-strict-aliasing -fwrapv -fPIC -I . -DUSEGLPK -g -I /usr/lib/ocaml -I /usr/lib/ocaml/bytes -I /usr/lib/ocaml/cudf -I /usr/lib/ocaml/extlib -I glpk -o mccs_stubs.o -c mccs_stubs.cpp)
In file included from /usr/include/c++/11/map:60,
                 from mccs_stubs.cpp:14:
/usr/include/c++/11/bits/stl_tree.h: In instantiation of ‘static const _Key& std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_S_key(std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Const_Link_type) [with _Key = CUDFVersionedPackage*; _Val = CUDFVersionedPackage*; _KeyOfValue = std::_Identity<CUDFVersionedPackage*>; _Compare = CUDFPackage_comparator; _Alloc = std::allocator<CUDFVersionedPackage*>; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_Const_Link_type = const std::_Rb_tree_node<CUDFVersionedPackage*>*]’:
/usr/include/c++/11/bits/stl_tree.h:2069:47:   required from ‘std::pair<std::_Rb_tree_node_base*, std::_Rb_tree_node_base*> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_get_insert_unique_pos(const key_type&) [with _Key = CUDFVersionedPackage*; _Val = CUDFVersionedPackage*; _KeyOfValue = std::_Identity<CUDFVersionedPackage*>; _Compare = CUDFPackage_comparator; _Alloc = std::allocator<CUDFVersionedPackage*>; std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::key_type = CUDFVersionedPackage*]’
/usr/include/c++/11/bits/stl_tree.h:2122:4:   required from ‘std::pair<std::_Rb_tree_iterator<_Val>, bool> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_insert_unique(_Arg&&) [with _Arg = CUDFVersionedPackage* const&; _Key = CUDFVersionedPackage*; _Val = CUDFVersionedPackage*; _KeyOfValue = std::_Identity<CUDFVersionedPackage*>; _Compare = CUDFPackage_comparator; _Alloc = std::allocator<CUDFVersionedPackage*>]’
/usr/include/c++/11/bits/stl_set.h:512:25:   required from ‘std::pair<typename std::_Rb_tree<_Key, _Key, std::_Identity<_Tp>, _Compare, typename __gnu_cxx::__alloc_traits<_Allocator>::rebind<_Key>::other>::const_iterator, bool> std::set<_Key, _Compare, _Alloc>::insert(const value_type&) [with _Key = CUDFVersionedPackage*; _Compare = CUDFPackage_comparator; _Alloc = std::allocator<CUDFVersionedPackage*>; typename std::_Rb_tree<_Key, _Key, std::_Identity<_Tp>, _Compare, typename __gnu_cxx::__alloc_traits<_Allocator>::rebind<_Key>::other>::const_iterator = std::_Rb_tree<CUDFVersionedPackage*, CUDFVersionedPackage*, std::_Identity<CUDFVersionedPackage*>, CUDFPackage_comparator, std::allocator<CUDFVersionedPackage*> >::const_iterator; typename __gnu_cxx::__alloc_traits<_Allocator>::rebind<_Key>::other = std::allocator<CUDFVersionedPackage*>; typename __gnu_cxx::__alloc_traits<_Allocator>::rebind<_Key> = __gnu_cxx::__alloc_traits<std::allocator<CUDFVersionedPackage*>, CUDFVersionedPackag
 e*>::rebind<CUDFVersionedPackage*>; typename _Allocator::value_type = CUDFVersionedPackage*; std::set<_Key, _Compare, _Alloc>::value_type = CUDFVersionedPackage*]’
mccs_stubs.cpp:316:43:   required from here
/usr/include/c++/11/bits/stl_tree.h:770:15: error: static assertion failed: comparison object must be invocable as const
  770 |               is_invocable_v<const _Compare&, const _Key&, const _Key&>,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/11/bits/stl_tree.h:770:15: note: ‘std::is_invocable_v<const CUDFPackage_comparator&, CUDFVersionedPackage* const&, CUDFVersionedPackage* const&>’ evaluates to false
make[1]: *** [debian/rules:14: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:9: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2