Bug#971439: Build procedure is incorrect and produces invalid files

[Stéphane Glondu <glondu@debian.org>]

severity 971439 important
thanks

Le 30/09/2020 à 18:12, Emilio Jesús Gallego Arias a écrit :
> Package: lablgtk3
> Version: 3.1.1-1
> 
> Dear OCaml maintainers,
> 
> as far as I could see this is a general bug on quite a few Debian OCaml
> packages; in particular submitting for lablgtk3 but this bug should be
> assigned to more packages.
> 
> It seems that the build procedure for lablgtk3 is incorrect, see for
> example https://github.com/coq/coq/issues/13079 , where the package
> contains and invalid META file; moreover as `-p` was not used the wrong
> compiler settings were used to build the binaries [for example regarding
> optimization]
> 
> OCaml packages that use dune as a build system _must_ be built:
> 
> - always with `dune build -p $pkg1,$pkg2` for the desired list of packages

I figured this out a while ago, and fix packages as I see them.
Unfortunately, running "dune build -p " with multiple packages does not
always work, and some times more convolutions are needed (see for
example lwt).

> and either:
> 
> - using the officially released .tbz archive that for example
>   dune-release produces, which will contain the right metadata for
>   version numbers, etc...
> 
> - or if using a git checkout, `dune subst` _must_ be run before the
>   build so the metadata is update prior build.

Oh... I wasn't aware of that. The policy in Debian is to take the
officially released .tbz. On the other hand, it is common to take a git
checkout, either because it is easier to monitor newer versions, or
because generated stuff are a pain. I don't know what motivated Ralf to
take a git checkout in the case of lablgtk3.

> Let us know if we can be of any help.

Thank you for your report! It would actually help if you could submit a
report (of severity important) for affected package if you find others.


Cheers,

-- 
Stéphane