[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#945246: marked as done (fails to build from source, attempts to install file in / rather than debian/tmp/)

Your message dated Wed, 22 Jan 2020 12:35:35 +0000
with message-id <E1iuFEN-0006wt-8f@fasolo.debian.org>
and subject line Bug#945246: fixed in liquidsoap 1.4.1-1
has caused the Debian Bug report #945246,
regarding fails to build from source, attempts to install file in / rather than debian/tmp/
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
945246: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945246
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: liquidsoap
Version: 1.4.0-1

While building the package, I received this error:

/usr/bin/install -c -m 644 scripts/bash-completion /usr/share/bash-completion/completions/liquidsoap
/usr/bin/install: cannot create regular file '/usr/share/bash-completion/completions/liquidsoap': Permission denied
make[2]: *** [Makefile:85: install-local] Error 1
make[2]: Leaving directory '/home/tsuyoshi/src/liquidsoap'
make[1]: *** [debian/rules:32: override_dh_auto_install] Error 2
make[1]: Leaving directory '/home/tsuyoshi/src/liquidsoap'
make: *** [debian/rules:14: binary] Error 2

This is because the installation of the bash-completion script is
not respecting DESTDIR, and thus installing it in / rather than
debian/tmp. The following patch fixes it.

diff --git a/debian/liquidsoap.install.in b/debian/liquidsoap.install.in
index 2f306d2..d2425e6 100644
--- a/debian/liquidsoap.install.in
+++ b/debian/liquidsoap.install.in
@@ -2,4 +2,4 @@ src/META @OCamlStdlibDir@/liquidsoap/
 etc/logrotate.d/liquidsoap
 usr/bin/liquidsoap
 usr/share/liquidsoap/*/* usr/share/liquidsoap
-etc/bash_completion.d/liquidsoap etc/bash-completion/completions
+usr/share/bash-completion/completions/liquidsoap
diff --git a/debian/rules b/debian/rules
index 808a3cb..697751e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -31,6 +31,7 @@ override_dh_auto_install:
 	chrpath -d src/liquidsoap
 	$(MAKE) install DESTDIR=$(DESTDIR) \
                prefix=$(DESTDIR)/usr sysconfdir=$(DESTDIR)/etc \
+	       bashcompdir=$(DESTDIR)/usr/share/bash-completion/completions \
                INSTALL_DAEMON=no OCAMLFIND_LDCONF=ignore
 	dh_install

--- End Message ---
--- Begin Message --- 
Source: liquidsoap
Source-Version: 1.4.1-1

We believe that the bug you reported is fixed in the latest version of
liquidsoap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 945246@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Kyle Robbertze <paddatrapper@debian.org> (supplier of updated liquidsoap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 22 Jan 2020 14:04:09 +0200
Source: liquidsoap
Architecture: source
Version: 1.4.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Kyle Robbertze <paddatrapper@debian.org>
Closes: 945246
Changes:
 liquidsoap (1.4.1-1) unstable; urgency=medium
 .
   * Install bash completions into packaging dir (Closes: #945246)
   * New upstream version 1.4.1
   * Bump Standards-Version to 4.5.0 (No change)
Checksums-Sha1:
 01ca058567b0eb5158ae468a89ae2cfbc2d8a16d 3502 liquidsoap_1.4.1-1.dsc
 52ce640599c8e07fbd39149190cb1f316789f19f 742613 liquidsoap_1.4.1.orig.tar.bz2
 cc03e9261259f9865dc85d62476c559b82f3d4a5 17104 liquidsoap_1.4.1-1.debian.tar.xz
 1b7f063375069fdba12ce0e4c09214d6d1e9137b 23456 liquidsoap_1.4.1-1_amd64.buildinfo
Checksums-Sha256:
 136977e882788952ac0513a791ed8cce64be34396723c7ca4147887b91a71283 3502 liquidsoap_1.4.1-1.dsc
 a4b3b20248896ace718e88456b343fc4b6a51167f6788c2dd7f08f9a5d010fec 742613 liquidsoap_1.4.1.orig.tar.bz2
 7394f50642e619deae47f4dcf06c77aa67b66fd35024a1d0f663b28ceeada752 17104 liquidsoap_1.4.1-1.debian.tar.xz
 1f51e5acf8addb6cb764b8a90cd57e76c7b2445fa2fb70f900a267bd6faebf06 23456 liquidsoap_1.4.1-1_amd64.buildinfo
Files:
 5d01d364073c237d23816a771bc07e78 3502 sound optional liquidsoap_1.4.1-1.dsc
 a14a955872916b0b712f804bffce0cc2 742613 sound optional liquidsoap_1.4.1.orig.tar.bz2
 900bf122fa7d2ffec762cc6fec685b2f 17104 sound optional liquidsoap_1.4.1-1.debian.tar.xz
 25d9fe2140bdd62eb9d318c90f37776c 23456 sound optional liquidsoap_1.4.1-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJMBAEBCgA2FiEElqWPGCu4+bgcXyczhU8Hvggt8U8FAl4oPLYYHHBhZGRhdHJh
cHBlckBkZWJpYW4ub3JnAAoJEIVPB74ILfFPcv0QAIXT3hInz8vlD39wHaTYf1kF
fa3mV/wUUnGaQ86JHLsiRREikVF9nwFGr/0g4y3LRCCkM1Mi+LiF0FE5lBuJLp/p
ipqMJ7yWasKZ1dIwFe1Xkvjrn2K9NqYs/1CF23UQatIgCwXepI8go1iuBGPUGoq7
Am0TnIs7R02YV1iYS/OcY4phKiueKTsHfbNY1GDbAaE0MpSzcvENhEPiiLIRwjrk
k8IX91BXW9+TGmQ2aVemcKD7mrizRp+V0An1xrNUbl/6YTUBJJmcRDwus2+zBADo
mLNLs6yLeX7qw5hkKeAcVTGvV/TXIU64bUClWeGHedXghas48b+SaMpz6vOsglDr
nxlMX+PONdOolSZ5SjTU3sMlI3wlzIDCvLqfLB0udvNy25hN9Mp3/VrioZ1YVh1+
dghDHqwgAEY21RTfuzKOYCr3JITEvzJJb1aeYDRjAJyeYmXoGPWa6CQxSltf92Mx
ChJFWXG646xIlBjcfO1NtSZLYcB/LEZgAlIQDpsuMqbDgnjEf5XeBNDwYUUSAjSr
aCUqNNNkzQHrnwAIMrLe/NaCAnjZ4YORvNveau+xNgv5xCtl30xFuhtwHvBKZSA7
dnmCJK6UNhiMH//GXzLrVE0kpVziaqjppScRD92Wae9akcrLDHIX9K8Pn5E6zctv
aaivFjFADQ5b0MGQTZta
=w8uR
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: