Bug#920466: mldonkey-server: Init script fails to stop daemon properly
Package: mldonkey-server
Version: 3.1.6-1+b1
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Dear Maintainer,
As part of adding mldonkey into FreedomBox, we noticed that the mldonkey-server
does not stop properly. This is because start-stop-daemon is asked to stop
based only on the PID file which is owned by non-root user. Making the process
match more specific fixes the problem.
# start-stop-daemon --stop --pidfile /var/run/mldonkey/mlnet.pid
start-stop-daemon: matching only on non-root pidfile
/var/run/mldonkey/mlnet.pid is insecure
# echo $?
2
# start-stop-daemon --stop --pidfile /var/run/mldonkey/mlnet.pid --exec
/usr/bin/mlnet
# echo $?
0
I have created a merge request to fix the issue. Tagging this issue with
'patch'.
https://salsa.debian.org/ocaml-team/mldonkey/merge_requests/1
- -- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_IN.UTF-8, LC_CTYPE=en_IN.UTF-8 (charmap=UTF-8),
LANGUAGE=en_IN.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages mldonkey-server depends on:
ii adduser 3.118
ii debconf [debconf-2.0] 1.5.70
ii libbz2-1.0 1.0.6-9
ii libc6 2.28-5
ii libgcc1 1:8.2.0-14
ii libgd3 2.2.5-5
ii libjpeg62-turbo 1:1.5.2-2+b1
ii libpng16-16 1.6.36-2
ii libstdc++6 8.2.0-14
ii lsb-base 10.2018112800
ii mime-support 3.61
ii ucf 3.0038+nmu1
ii zlib1g 1:1.2.11.dfsg-1
mldonkey-server recommends no packages.
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE5xPDY9ZyWnWupXSBQ+oc/wqnxfIFAlxLhiMRHHN1bmlsQG1l
ZGhhcy5vcmcACgkQQ+oc/wqnxfK/1w/9H/vFfCW/N7EM1DkzWkHoNzKtaW/Xn0Ih
rJzb7fUyq3LFBexILTMHvgz8d/hPoRFuktgY2Thvq8E546bRB4oYfStXfFO+njXd
LkMKEPhyKqTgOfRjCMKVr7QUtBpYN5XBze99esEhIGzg9Al/vZXyBxtz4voFJ2LL
R0p/0FlWCT6fXsy3z0T5Mfm0jV4IyC42bh/1MemzR7ATmvc6mL9/TMXV3vZEdX2A
OMu+XRkJhown5vQVeC32hfJWreb5J93urVPdHXltXZb5tJjvx9X3tfNAK3i/EEx+
5aXktK4/TP8BAj/A2uJ6yxf4vE5HFPxrca8ZrX4qcjstHuaB/yGCru2oWaUzkBD5
0RFn5HOtwXI8NXVP6zTIimVQqkoXzeY8SQsSQBToWkxjJchXQ0u9EiijdZM5nDNJ
qfJVp/qk6okK9MerP2sNwtHAWyxgOa5iqFrifITmLoJfZrmtkkg4VRs1eYpCGHr9
v9E2wCsKfRp2V/tKzASbxk6Oc7P7iEBWMmQTAmuSmK84k2VvQTwjMy+OCOOeIue5
Gqdwz1+BgpIF4baRgIalYIu9iGHfQBErfY3GLgcdjJx+ketfqZHw3VTlLjCipfUt
D/ppP5q4FlHnlb5OraNakVwei1Bdn2wK7UnevjqGcMMYRm5m1YkK3Ci3gUnwz4zv
Ruln29zlUD8=
=5KnO
-----END PGP SIGNATURE-----
Reply to: