[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#910222: opam: copyright file missing after upgrade (policy 12.5)



Package: opam
Version: 2.0.0-4
Severity: serious
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#copyright-information

After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.

This was observed on the following upgrade paths:

  stretch -> buster

>From the attached log (scroll to the bottom...):

0m52.3s ERROR: WARN: Inadequate results from running adequate!
  opam: missing-copyright-file /usr/share/doc/opam/copyright

  MISSING COPYRIGHT FILE: /usr/share/doc/opam/copyright
  # ls -lad /usr/share/doc/opam
  drwxr-xr-x 2 root root 40 Sep 24 12:23 /usr/share/doc/opam
  # ls -la /usr/share/doc/opam/
  total 0
  drwxr-xr-x   2 root root   40 Sep 24 12:23 .
  drwxr-xr-x 137 root root 3440 Sep 24 12:23 ..


Additional info may be available here:
https://wiki.debian.org/MissingCopyrightFile

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-unpack-phase-of-installation-or-upgrade

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.maintscript.
Do not forget to add 'Pre-Depends: ${misc:Pre-Depends}' in d/control.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


cheers,

Andreas

Attachment: opam_2.0.0-4.log.gz
Description: application/gzip


Reply to: