[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#882786: FTBFS against ffcall 2.0: can't find callback library



Package: src:mlpcap
Version: 0.9-17
Severity: serious

Dear Maintainer,

mlpacp FTBFS against ffcall 2.0, that has just been uploaded to unstable.

The minimal fix consists in changing the symbol from the callback library that
is tested in conigure.in (replacing "alloc_trampoline_r" by
"callback_trampoline_alloc").

I attach a patch that implements more than this minimal fix:
- it uses the new preferred name for the -dev package
- and it relies on the new libffcall.so (instead of the former libcallback.so,
  which still exists for backward compatibility).

Best,

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org
diff -Nru mlpcap-0.9/debian/changelog mlpcap-0.9/debian/changelog
--- mlpcap-0.9/debian/changelog	2017-08-08 15:50:26.000000000 +0200
+++ mlpcap-0.9/debian/changelog	2017-11-09 15:33:21.000000000 +0100
@@ -1,3 +1,11 @@
+mlpcap (0.9-17.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Replace libffcall1-dev by libffcall-dev.
+  * 08_ffcall.diff: new patch for compiling against ffcall ≥ 2.0. (Closes: #-1)
+
+ -- Sébastien Villemot <sebastien@debian.org>  Thu, 09 Nov 2017 15:33:21 +0100
+
 mlpcap (0.9-17) unstable; urgency=medium
 
   [ Stéphane Glondu ]
diff -Nru mlpcap-0.9/debian/control mlpcap-0.9/debian/control
--- mlpcap-0.9/debian/control	2017-08-08 15:49:12.000000000 +0200
+++ mlpcap-0.9/debian/control	2017-11-09 15:33:21.000000000 +0100
@@ -8,7 +8,7 @@
  debhelper (>= 10),
  ocaml-nox (>= 3.10.0-9),
  camlidl (>= 1.05-10),
- libffcall1-dev,
+ libffcall-dev,
  ocaml-findlib (>= 1.1.2pl1-4),
  libpcap0.8-dev,
  dh-ocaml (>= 0.9.1)
@@ -26,7 +26,7 @@
 
 Package: libmlpcap-ocaml-dev
 Architecture: any
-Depends: ${ocaml:Depends}, libmlpcap-ocaml (= ${binary:Version}), libffcall1-dev, libpcap0.8-dev, camlidl, ${misc:Depends}
+Depends: ${ocaml:Depends}, libmlpcap-ocaml (= ${binary:Version}), libffcall-dev, libpcap0.8-dev, camlidl, ${misc:Depends}
 Provides: ${ocaml:Provides}
 Description: binding of libpcap for OCaml
  MLpcap implements OCaml stubs to libpcap. It allows one to call almost
diff -Nru mlpcap-0.9/debian/patches/08_ffcall.diff mlpcap-0.9/debian/patches/08_ffcall.diff
--- mlpcap-0.9/debian/patches/08_ffcall.diff	1970-01-01 01:00:00.000000000 +0100
+++ mlpcap-0.9/debian/patches/08_ffcall.diff	2017-11-09 15:33:21.000000000 +0100
@@ -0,0 +1,23 @@
+Description: Fix detection of callback library 
+ The callback library is now embedded in libffcall, and the symbol names have
+ changed, hence fix the configure test.
+Author: Sébastien Villemot <sebastien@debian.org>
+Forwarded: no
+Last-Update: 2017-11-09
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/configure.in
++++ b/configure.in
+@@ -77,9 +77,9 @@ dnl ---------------
+ dnl Ffcall callback
+ dnl ---------------
+ 
+-AC_CHECK_LIB(callback,
+-             alloc_trampoline_r,,
+-             AC_MSG_ERROR([can't find callback library.]))
++AC_CHECK_LIB(ffcall,
++             callback_trampoline_alloc,,
++             AC_MSG_ERROR([can't find ffcall library.]))
+ 
+ dnl Header
+ 	
diff -Nru mlpcap-0.9/debian/patches/series mlpcap-0.9/debian/patches/series
--- mlpcap-0.9/debian/patches/series	2017-08-08 15:40:55.000000000 +0200
+++ mlpcap-0.9/debian/patches/series	2017-11-09 15:33:21.000000000 +0100
@@ -4,3 +4,4 @@
 02_ocamlfind_for_example.diff
 03_correct_META.diff
 07_dll_with_camlidl.diff
+08_ffcall.diff
diff -Nru mlpcap-0.9/debian/rules mlpcap-0.9/debian/rules
--- mlpcap-0.9/debian/rules	2017-08-08 15:40:30.000000000 +0200
+++ mlpcap-0.9/debian/rules	2017-11-09 15:33:21.000000000 +0100
@@ -19,6 +19,7 @@
 
 include /usr/share/cdbs/1/rules/ocaml.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
+include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/class/autotools.mk
 
 PACKAGE := libmlpcap-ocaml

Attachment: signature.asc
Description: PGP signature


Reply to: