Hi, Quoting Johannes Schauer (2017-01-11 21:40:21) > The idea is to replicate the dependency satisfaction logic that > dpkg-checkbuilddeps uses. > > If you say --build=source then it will only evaluate the contents of > Build-Depends and Build-Conflicts (and not Build-Depends-Indep, > Build-Conflicts-Indep, Build-Depends-Arch or Build-Conflicts-Arch). > > We have --deb-drop-b-d-indep but that only allows differentiating between full > and arch-all-only builds. We could also add --deb-drop-b-d-arch but using the > --deb-build=type interface I proposed above would: > > - make the dose-debbuildcheck call closer to what one would use with > dpkg-buildpackage and thus easier to remember > - avoid having to memorize which --deb-drop-b-d-* option is for which type of > build > > If we would instead add a --deb-drop-b-d-arch option, then the mapping from > dpkg-buildpackage to dose3 options would be as follows: > > dpkg dose3 > > --build=source --deb-drop-b-d-arch --deb-drop-b-d-indep > > --build=any --deb-drop-b-d-indep > > --build=all --deb-drop-b-d-arch > > --build=binary (none) > > --build=full (none) > > So a disadvantage of a --deb-build=type option would be that the "binary" and > "full" arguments would be functionally equivalent. This would be an argument > to use the --deb-drop-b-d-arch variant instead. after thinking about this more, I got convinced that a --deb-build option would not make much sense for dose3 and that a --deb-drop-b-d-arch option is better for the following reasons: - the --deb-build=binary and --deb-build=full options are redundant - --deb-drop-b-d-indep already exists and it would be bad to break backwards compatibility by removing it in favor of --deb-build - the dpkg-checkbuilddeps tool doesn't use the --build option but instead -A and -B. So if we use --deb-drop-b-d-arch and --deb-drop-b-d-indep then dose3 will have an interface similar to dpkg-checkbuilddeps which makes sense I put my implementation in commit 90e81c2 in the dose3 master branch. Thanks! cheers, josch
Attachment:
signature.asc
Description: signature