Hi, As you might have seen, I forwarded the patch upstream, added metadata to the effect and added --fail-missing (and relevant excludes), so it should be ready for you to re-review and upload. Best, nicoo On Sun, Jul 31, 2016 at 09:57:49PM +0200, Nicolas Braud-Santoni wrote: > On Sat, Jul 30, 2016 at 11:08:21AM +0200, Stéphane Glondu wrote: > > On 24/07/2016 04:48, Nicolas Braud-Santoni wrote: > > > ## apron > > > > I've looked at this and have comments about two commits: > > > > * ccfc263ea7c50bbdf70544a4e679ed4f8e9053bf: How did you come up with > > that? These files (symlinks) were not installed before, right? I > > usually like to override dh_install with dh_install --fail-missing > > to spot files that are installed in debian/tmp but not in any binary > > package, I suggest you to do that. > > That's exactly what I did (well, using `--list-missing`), but I didn't > feel I should change this, given that I'm not the package maintainers > and they might have another opinion on this. > > > > * d134360601be34fe10658d2020a15695e403c454: This should be forwarded > > upstream. > > Yes, I wrote myself a note to do it ... and forgot anyway :V > > > Thanks a lot for the review, > > nicoo
Attachment:
signature.asc
Description: PGP signature