[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#810303: dose-builddebcheck output breaks backwards compatibility in 4.1 dropping the "src:" prefix, worth NEWS?



Hi

On 20/01/2016 01:10, Pietro Abate wrote:
> Hi
> 
> On 20/01/16 00:00, Mehdi Dogguy wrote:
>> Only did a quick grep:
>>
>> % git grep -n "\"src:" **/*.ml
>> applications/deb-buildcheck.ml:182:          let (name,filter) = Debian.Debutil.debvpkg to_cudf (("src:"^n,a),c) in
> 
> Here I append "src:" to the name of a debian package to find the
> corresponding cudf package
> 
>> deb/debcudf.ml:343:    if String.starts_with pkg#name "src:" then
>> deb/sources.ml:235:  let sn = CudfAdd.encode ("src:"^(CudfAdd.get_property "source" binpkg)) in
> 
> These two are part of the debian <-> cudf encoding. The first one
> removes the "src:" prefix. The second one adds the prefix to the debian
> package.
> 
>> deb/tests.ml:875:      "any/native", "src:source1", returns [
>> deb/tests.ml:883:      "stage1", "src:source2", returns [
>> deb/tests.ml:892:      "indep", "src:source3", returns [
> And these are test cases...
> 
>> Are those occurences expected?
> 
> so, yes. These are all expected. The src: prefix is still used to
> encode source packages in cudf (and to differentiate to binary
> packages). The difference from the previous release is that this
> encoding is not visible anymore to the final user in the yaml report.
> 

Ah. Indeed. Thanks for the clear explanation! It all makes sense now :)

Cheers,

-- 
M


Reply to: