[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Uploads needed



On 24/07/2016 04:48, Nicolas Braud-Santoni wrote:
## apron

- Many cleanups (Vcs-* URLs, Standards-Version, copyright, typos)
- Made libapron-dev depend on libapron, fixing broken symlinks
   discovered by piuparts (#715070)
- Move some shlib symlinks to libapron-dev.
   Breaks and Replaces were set accordingly.
- Use build-time hardening for the C parts
- Added doc-base metadata

I've looked at this and have comments about two commits:

* ccfc263ea7c50bbdf70544a4e679ed4f8e9053bf: How did you come up with
  that? These files (symlinks) were not installed before, right? I
  usually like to override dh_install with dh_install --fail-missing
  to spot files that are installed in debian/tmp but not in any binary
  package, I suggest you to do that.

* d134360601be34fe10658d2020a15695e403c454: This should be forwarded
  upstream.


Cheers,

--
Stéphane


Reply to: