[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749261: marked as done (ocaml: Please add support for OpenRISC/or1k architecture)



Your message dated Fri, 28 Aug 2015 11:14:48 +0200
with message-id <55E02688.8050305@debian.org>
and subject line Re: Bug#749261: ocaml: Please add support for OpenRISC/or1k architecture
has caused the Debian Bug report #749261,
regarding ocaml: Please add support for OpenRISC/or1k architecture
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
749261: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749261
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: ocaml
Version: 4.01.0-3
Severity: normal
Tags: upstream patch

Hi,

The patch provided allows to get this package compiled in OpenRISC/or1k
architecture that Christian and I are creating in Debian.

I don't know if the support is perfect/complete, but at least it already
allowed us to compile many ocaml-based packages from Debian unstable.

It would be helpful if you could add the patch soonish, so we do not
have to carry local patches and future versions of the package build
cleanly from the Debian archives.

The patch was created against the previous version, not the latest
uploaded a few days ago, but it should be trivial for you to modify it
(indeed, it only adds 2 lines).


Cheers.
--
Manuel
Description: Support for OpenRISC/or1k architecture
 This patch adds support for the OpenRISC/or1k architecture.
Author: Manuel A. Fernandez Montecelo <mafm@debian.org>
Last-Update: 2014-05-25

diff -Nru ocaml-4.01.0/debian/changelog ocaml-4.01.0/debian/changelog
--- ocaml-4.01.0/debian/changelog	2013-12-02 19:03:03.000000000 +0000
+++ ocaml-4.01.0/debian/changelog	2014-04-06 23:57:49.000000000 +0100
@@ -1,3 +1,10 @@
+ocaml (4.01.0-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * or1k port (enable native compiler in this arch)
+
+ -- Manuel A. Fernandez Montecelo <mafm@debian.org>  Sun, 06 Apr 2014 23:57:13 +0100
+
 ocaml (4.01.0-3) unstable; urgency=low
 
   * Upload to unstable
diff -Nru ocaml-4.01.0/debian/natdynlink-archs ocaml-4.01.0/debian/natdynlink-archs
--- ocaml-4.01.0/debian/natdynlink-archs	2013-12-02 17:40:05.000000000 +0000
+++ ocaml-4.01.0/debian/natdynlink-archs	2014-04-07 00:35:06.000000000 +0100
@@ -1 +1 @@
-amd64 armel armhf hurd-i386 i386 kfreebsd-i386 kfreebsd-amd64 lpia powerpc sparc
+amd64 armel armhf hurd-i386 i386 kfreebsd-i386 kfreebsd-amd64 lpia or1k powerpc sparc
diff -Nru ocaml-4.01.0/debian/native-archs ocaml-4.01.0/debian/native-archs
--- ocaml-4.01.0/debian/native-archs	2013-12-02 17:40:05.000000000 +0000
+++ ocaml-4.01.0/debian/native-archs	2014-04-06 23:57:48.000000000 +0100
@@ -1 +1 @@
-amd64 armel armhf hurd-i386 i386 kfreebsd-i386 kfreebsd-amd64 lpia powerpc sparc
+amd64 armel armhf hurd-i386 i386 kfreebsd-i386 kfreebsd-amd64 lpia or1k powerpc sparc
diff -Nru ocaml-4.01.0/debian/patches/or1k-configure ocaml-4.01.0/debian/patches/or1k-configure
--- ocaml-4.01.0/debian/patches/or1k-configure	1970-01-01 01:00:00.000000000 +0100
+++ ocaml-4.01.0/debian/patches/or1k-configure	2014-04-07 00:34:14.000000000 +0100
@@ -0,0 +1,10 @@
+--- a/configure
++++ b/configure
+@@ -715,6 +715,7 @@
+   x86_64-*-netbsd*)             arch=amd64; system=netbsd;;
+   x86_64-*-openbsd*)            arch=amd64; system=openbsd;;
+   x86_64-*-darwin*)             arch=amd64; system=macosx;;
++  or1k-*-gnu*)                  arch=or1k; system=gnu;;
+ esac
+ 
+ # Some platforms exist both in 32-bit and 64-bit variants, not distinguished
diff -Nru ocaml-4.01.0/debian/patches/series ocaml-4.01.0/debian/patches/series
--- ocaml-4.01.0/debian/patches/series	2013-12-02 17:40:05.000000000 +0000
+++ ocaml-4.01.0/debian/patches/series	2014-04-07 00:32:56.000000000 +0100
@@ -13,3 +13,4 @@
 0013-Tune-resource-usage-of-some-tests.patch
 0014-Native-backtraces-don-t-work-on-powerpc-and-sparc.patch
 0015-Fix-native-backtraces-on-arm.patch
+or1k-configure

--- End Message ---
--- Begin Message ---
Le 27/08/2015 20:41, Manuel A. Fernandez Montecelo a écrit :
>>> I don't know if the support is perfect/complete, but at least it already
>>> allowed us to compile many ocaml-based packages from Debian unstable.
>>
>> Really? Your patch only touches the configure script. Adding native
>> support for a new architecture is more than that. On the other hand,
>> adding support for a bytecode archecture should be pretty easy. Didn't
>> you forget some files?
> 
> That is all that I had, or perhaps I had a bit more but it was not
> ready to submit.

You're missing at least directory asmcomp/or1k and file asmrun/or1k.S.
What is the output of the "Configuration for the native-code compiler"
section in ./configure output with your patch?

Besides, debian/control needs to be regenerated when debian/native-archs
is modified.

My feeling is that your patch is without effect. Doesn't the ocaml
package compile without your patch?

> Sometimes, getting the deb binary package built (even if it does not
> actually work) enables other packages to be able to be satisfy build
> depends and be built, even with deficiencies (e.g. missing
> documentation or modules) -- so yes, even if the language is not
> actually ported, it is not a completely useless exercise either.

As I said, getting the bytecode compiler work should be easy (if there
is anything to do at all) and is enough to compile the (OCaml) world.
Getting the native compiler work is a more ambitious endeavour and
probably not something one would do first when bootstrapping a new
Debian architecture...

> However, one year later, the port is in the freezer now and perhaps
> never to be continued, so you can ignore the bug or close it.

OK, closing then. Feel free to reopen when development on the port resumes.


Cheers,

-- 
Stéphane

--- End Message ---

Reply to: