[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#779037: marked as done (dh-ocaml: please make the build reproducible)

Your message dated Wed, 12 Aug 2015 15:51:37 +0000
with message-id <E1ZPYJV-0006B8-9P@franck.debian.org>
and subject line Bug#779037: fixed in dh-ocaml 1.0.10
has caused the Debian Bug report #779037,
regarding dh-ocaml: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
779037: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779037
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: dh-ocaml
Version: 1.0.9
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that dh-ocaml generates /var/lib/ocaml/lintian/libfoo-ocaml-dev.info
files with a non-deterministic order.

The attached patch removes this randomness from the build system.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

diff --git a/debhelper/dh_ocaml b/debhelper/dh_ocaml
index de4535b..05b1981 100755
--- a/debhelper/dh_ocaml
+++ b/debhelper/dh_ocaml
@@ -353,7 +353,7 @@ foreach my $package (keys(%dev_packages), @binary_packages)
 
     # Search for OCaml bytecode binaries and objects
     open(OLIST, ">", $olist_fn) unless $dh{NO_ACT};
-    find sub {
+    find {'wanted' => sub {
         (-f $_)
         &&
         (-x $_ && test_bytecode($_) || /\.cm([iaox]|x[as])$/)
@@ -363,6 +363,10 @@ foreach my $package (keys(%dev_packages), @binary_packages)
         (!$dh{NO_ACT})
         &&
         (print OLIST $File::Find::name."\n")
+      },
+      'preprocess' => sub {
+        return sort @_;
+      }
     }, @search_path;
     close(OLIST) unless $dh{NO_ACT};
     doit("cat $olist_fn") if $dh{VERBOSE};

--- End Message ---
--- Begin Message --- 
Source: dh-ocaml
Source-Version: 1.0.10

We believe that the bug you reported is fixed in the latest version of
dh-ocaml, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 779037@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stéphane Glondu <glondu@debian.org> (supplier of updated dh-ocaml package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 12 Aug 2015 16:44:39 +0200
Source: dh-ocaml
Binary: dh-ocaml
Architecture: source all
Version: 1.0.10
Distribution: unstable
Urgency: medium
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Stéphane Glondu <glondu@debian.org>
Description:
 dh-ocaml   - helper tools for maintaining OCaml-related Debian packages
Closes: 500036 779037
Changes:
 dh-ocaml (1.0.10) unstable; urgency=medium
 .
   [ Riley Baird ]
   * Added option to set alioth username in dom-git-new-repo
 .
   [ Stéphane Glondu ]
   * Use a deterministic order in generated .info files. Patch by Chris
     Lamb (Closes: #779037)
   * Policy: allow installation of *.{cmxs,cma,cmo} and META in runtime
     packages (and other minor changes) (Closes: #500036)
   * Bump debhelper compat level to 9
   * Bump Standards-Version to 3.9.6
Checksums-Sha1:
 5d18e23a2be2ddd10546c565f613c8493f5f2bf3 1846 dh-ocaml_1.0.10.dsc
 fbde59c4bb9dd260196c7dac45031ab19845a08b 47304 dh-ocaml_1.0.10.tar.xz
 b3ee92a1218b8cb6b2ccda305e543940ba735b68 83744 dh-ocaml_1.0.10_all.deb
Checksums-Sha256:
 400ff723cd0d1fa2ef1c874777d75fb1f24c544d80f076d566a3888451e600e5 1846 dh-ocaml_1.0.10.dsc
 911cbb910ac68b03867ef4b9770ed67912aba9a87d45afd4102b2ce39d616943 47304 dh-ocaml_1.0.10.tar.xz
 97a2352de40c9189f88bdbe8911cd9b5de031e59d21ca1e95396d576685033cc 83744 dh-ocaml_1.0.10_all.deb
Files:
 082dfdeeb0397739c5ecb69e309e0055 1846 ocaml extra dh-ocaml_1.0.10.dsc
 8fa64e7292547e3d99fd820aa814bea0 47304 ocaml extra dh-ocaml_1.0.10.tar.xz
 151f5cb82b9134427841be504c6ec1a0 83744 ocaml extra dh-ocaml_1.0.10_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJVy1xlAAoJEHhT2k1JiBrTPOMP/Rh9f6KtRKyURfWueJJLviW2
Lc38XeQJ13KzptrW3bLhQjTeL3uu6XCT5fdmiFsfG4reuDDevLXIyBxL1F3aQXjy
4ML85YAXn4CgiQbk1bAbJa6j2fAN9oKIyvjYzPVLMpWI10c/i1PU4YPGBW3VXMaY
+7zlVA4hFipiy6J1eSU5C2lpcpwvyzwttNmhv9OHu9RQ2Epxn2KGDAi+k5wcjI5n
qcmmFXUAevjSsjHEngdYSFRJc9DQEjCdqwzVr+vo4mWyRzXsqFhMYtwAs9NAKjTA
lkEr70cLUdFKfCMi+SbSZfnXoWbLvr+DFr5kCyUbFH7T95K0m9yD23sdPBiflPW8
60la8b5WMXBKqXhlRlLvHmO+El+WgpqcLVJs3gwEG5EslLK7jRMjraleza7hEXKM
7OgheJqGDJXtf41JjjykFX0maDicsB82dpbou5foNjzCXT82NVY2yD6ogcf95v2Z
Qc4YxFPu0RhKQ6GDpJHn65o+H2+oB8BNr3/MhzkPktyxzEw2+2jxpftj2HSjNGlO
9jwZMV79nXxkq6oX6YZBjiJxNSJNiXzrX98iIt114g4n2u2MhehGqo4ns1hmMZHQ
ghlr7Z5uI41bRmU4Quq0MN6cnxVdMNh3WH87Hg+q90flL7KnXKYNUCAhJ5kMdB3R
4u9SfYf/D91kXa/bZyx6
=WQzL
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: