[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#786846: alt-ergo: [PATCH] please make the build reproducible - set build date



[I'm not the maintainer, just a random bug onlooker.]

Hi Juan!

* Juan Picca <jumapico@gmail.com>, 2015-05-25, 22:33:
+BUILD_DATE = $(shell LANG=en_US; date)

There are multiple problems with this command line:
- If LANG is wasn't exported in the environment, then setting it won't have any effect on the date command.
- Not everyone has the en_US locale installed.
- Setting LANG is not the proper way to reset environment, because LANG can be overridden by various LC_* variables.

All in all, this line should read:

BUILD_DATE = $(shell LC_ALL=C date)

--
Jakub Wilk


Reply to: