[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#681663: marked as done (omake: wrong link option order in CheckCLib breaks with ld-as-needed)



Your message dated Tue, 04 Feb 2014 09:36:03 +0000
with message-id <E1WAcQF-0000kO-7s@franck.debian.org>
and subject line Bug#681663: fixed in omake 0.9.8.5-3-9
has caused the Debian Bug report #681663,
regarding omake: wrong link option order in CheckCLib breaks with ld-as-needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
681663: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=681663
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: omake
Version: 0.9.8.5-3
Severity: important
Tags: upstream patch
Usertags: ld-as-needed

Dear Maintainer,

OMake "CheckCLib" function uses CFLAGS instead of LDFLAGS to pass link
options. This causes this test to fail with ld-as-needed, since "-l"
option appears on the command-line before objects which use the library.

In particular, the package camlimages fails to build properly because of
this bug: it fails to check the existence of libpng, libjpeg, ..., using
CheckCLib.

Fixing the bug is easy: one only need to replace CFLAGS with LFLAGS in
the definition of CheckCLib (lib/configure/Configure.om).

Upstream bug: http://bugzilla.metaprl.org/cgi-bin/show_bug.cgi?id=738

Upstream camlimages workaround:
https://bitbucket.org/camlspotter/camlimages/changeset/7e9024c0cd0a

Ubuntu bug for camlimages:
https://bugs.launchpad.net/ubuntu/+source/camlimages/+bug/1019222
--- omake-0.9.8.5-3.orig/lib/configure/Configure.om
+++ omake-0.9.8.5-3/lib/configure/Configure.om
@@ -268,7 +268,7 @@ public.VerboseCheckCHeader(files) =
 # \end{doc}
 #
 public.CheckCLib(libs, funs) =
-    CFLAGS += $(addprefix -l, $(libs))
+    LDFLAGS += $(addprefix -l, $(libs))
 
     return $(TryLinkC $"""
 #ifdef __cplusplus

--- End Message ---
--- Begin Message ---
Source: omake
Source-Version: 0.9.8.5-3-9

We believe that the bug you reported is fixed in the latest version of
omake, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 681663@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stéphane Glondu <glondu@debian.org> (supplier of updated omake package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 04 Feb 2014 08:45:22 +0100
Source: omake
Binary: omake omake-doc
Architecture: source amd64 all
Version: 0.9.8.5-3-9
Distribution: unstable
Urgency: medium
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Stéphane Glondu <glondu@debian.org>
Description: 
 omake      - build system with automated dependency analysis
 omake-doc  - documentation for OMake
Closes: 599322 681663 715043 737592
Changes: 
 omake (0.9.8.5-3-9) unstable; urgency=medium
 .
   * Team upload
   * Disable fatal warnings (Closes: #737592)
   * Use LDFLAGS instead of CFLAGS for ld-as-needed (Closes: #681663)
   * Use dh_ocaml for automatic dependencies (Closes: #599322)
   * Recompile with new libfam0 (Closes: #715043)
   * Bump debhelper compat to 9
   * Update Vcs-*
   * Remove myself from Uploaders
Checksums-Sha1: 
 04739dd90a126f7aa23b01c0d4ce4e17aec52546 2031 omake_0.9.8.5-3-9.dsc
 0cee55b44a0e9e4d7080c6c44ed6beaa45ffef7d 6900 omake_0.9.8.5-3-9.debian.tar.xz
 0f13b8090f1d600deff1aaa9d20d235016e88b41 731346 omake_0.9.8.5-3-9_amd64.deb
 e0ee76b3fbb47ab86cf691946fcaf57219e07593 723284 omake-doc_0.9.8.5-3-9_all.deb
Checksums-Sha256: 
 411caf904a7081dc81af94beaa66940ca2249c45b1b5b007a31d99c5a5ab1327 2031 omake_0.9.8.5-3-9.dsc
 8343b13579fe123eac974a48834c69420a25d76c6ac4c822d04825987eeaa192 6900 omake_0.9.8.5-3-9.debian.tar.xz
 786e573869387c9b4c833ea8f3f3d662d1dfdb48443fd8ec233c5b864bdc9866 731346 omake_0.9.8.5-3-9_amd64.deb
 b52323dd79454b48a1348a9a1898624cc1417163e8dbfa7c5730d3d2e64b29b6 723284 omake-doc_0.9.8.5-3-9_all.deb
Files: 
 e75460b6dee22ff34da0640f12ac033c 2031 ocaml optional omake_0.9.8.5-3-9.dsc
 cf98fba01fb60e8821ce8273f3cf9ae2 6900 ocaml optional omake_0.9.8.5-3-9.debian.tar.xz
 e9117effa0918cdc22696c3dc871e5c4 731346 ocaml optional omake_0.9.8.5-3-9_amd64.deb
 65c2db361ab83a96055e0b8c1e8636da 723284 doc optional omake-doc_0.9.8.5-3-9_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS8J7AAAoJEHhT2k1JiBrTKPYQAKgYppTgfwSacazGEatxUil9
cI3cG4qfEzaZYo0THRcMBFMkPZ+BrUrARK0rXeqm40BVgaNPmfnSSGHI6AdjIKor
zJLZVVKdDezNonNgTOdePWuN+xgavggNdwBx0M+wPGvlgRPUUUefBNFSCa9L8Li+
gfVZn+78kwnTymUwZExHCugHQea8jy1eAxJPUyQoBtTzcNqgwQL/ba6ZsgzyVUnj
uXUsyCpEngCo9xLPni18I2QFv0LndzcbQvJIjPkx0/xgSaDKmZIguWWowXM32AuT
gMm6G1wc2mFxbJ715LQ7TRD7tKGQ2vEQ3uhiFLj1Z/iv0+JIlAMjSeLYroH8kVjQ
g41wTw4farqegWLRbohjYrr2X6vqfpU5EbnXPX4kYh5Hg4usiD1b4F8s0DanzxPU
lo0E80gcuTKFn57Tcdmnz5YA2zOG3W55dwI3SfnYHiJcP2QKRYT4FREnyk6+CdaT
Q6jdz36KUq0+fmLsqQUuL1OSjGtQPRCaEq0XGABDS+N15uovuG/nF2WRzPBYcgHR
mURKNJM5OiTgJgzzqu6i0xGGhAVyOSN6nkxgQ1093epaN4Tpu9df3Ukasb8jTmFF
gkBboC872PsBj2FeL/T+LicQU1NswltaYyMIKiIbVy5XaTqla6pxSFxrCgyncnfE
x3lR+NaeZ6kpGqXxkNhB
=nJUA
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: