Re: ocaml-csv updated

[Lifeng Sun <lifongsun@gmail.com>]

Hi,

On 12:51 Sun 07/07/13 Jul     , Stéphane Glondu wrote:
> It failed again...

I find csvtool compiled to csvtool.bytecode on my mipsel (non-native)
box, that's why the previous fixing didn't work.

> I had a closer look. The package was built with
> DESTDIR=$(CURDIR)/debian/libcsv-ocaml-dev, which is not something I
> recommend, escpecially when there are servery binary package. IMHO, it's
> better to use debian/tmp, and dispatch files using *.install files and
> dh_install --fail-missing.
> 
> Looking closer at the history, I realise using debian/libcsv-ocaml-dev
> was my fault, but at the time csvtool was not installed by upstream
> build system, but everything installed by upstream build system was put
> in libcsv-ocaml-dev so it worked that way.
> 
> With the new version, csvtool started being installed directly by
> upstream build system. I assume you observed that csvtool popped up in
> libcsv-ocaml-dev binary package and you tried to fix it by moving files
> around, but the correct solution is the switch to debian/tmp and
> *.install files. If there is a failure this way, it's upstream's fault
> (but usually oasis does things right).

I followed your approach and set DESTDIR to $(CURDIR)/debian/tmp, it
works perfectly and the packaing stuff is more concise now.

Thank you very much!


Cheers,
Lifeng

--