[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#676858: tuareg-mode: emacs21 require 'derived



Ralf Treinen <treinen@free.fr> writes:
>
> +(if (and (featurep 'emacs) (= emacs-major-version 21))
> +    (require 'derived))

I think it'd be better to check for the func required, since looking at
version numbers tends to be fragile.

    (unless (fboundp 'derived-mode-p) ;; in derived.el in emacs21
      (require 'derived))

But I'd still suggest an unconditional require.  The use of

    (define-derived-mode tuareg-mode ...

will load derived.el into all emacs versions, so I don't think anything
is saved by conditionalizing it at the start.




-- 
One is treated well there but has to pay dearly for it.
  -- Denis Diderot reviewing the first ever Paris restaurant.
     This gripe, or some version thereof, has been fashionable ever
     since.  (Tony White)



Reply to: