Bug#667447: "common.o" not included in "dllsdlgfxstub.so"

[Olivier Andrieu <oandrieu@gmail.com>]

On Mon, Jun 18, 2012 at 10:20 AM, Stéphane Glondu <glondu@debian.org> wrote:
> Le 18/06/2012 00:27, Florent Monnier a écrit :
>> In the current ocamlsdl the libs "libsdlgfxstub.a" and "dllsdlgfxstub.so" uses
>> functions that are defined in "common.c" but these libs are built without
>> "common.o".
>>
>> Now the module "Sdlgfx" in made to work with "Sdlvideo" which stub is built
>> with "common.o", so the fact that some symbols are missing in gfx's stub is
>> hidden.

Actually the extra inclusion of common.o was hiding the fact that the
Sdlgfx→Sdlvideo dependency wasn't correctly set in the META file.

> IIUC: Sdlgfx depends on Sdlvideo, and common.o is built in Sdlvideo's
> stub (-lsdlstub) and used by Sdlgfx (-lsdlgfxstub). It looks fine to me
> without the patch, then. Moreover, it looks like the patch duplicates
> common.o (in -lsdlstub and in -lsdlgfxstub), which is actually bad.

Yes, exactly.

-- 
  Olivier