Re: Bug#587982: glmlite: changing back from ITP to RFP
Le 27/02/2011 01:42, Florent Monnier a écrit :
> It's true that some examples are made to work in the source tree, but I made
> patches for this in the mandriva package and I have given yet the link for
> this : http://lists.debian.org/debian-ocaml-maint/2010/03/msg00013.html
> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/ocaml-
> glmlite/current/SOURCES/
These patches are too intrusive and not robust enough to be part of a
Debian package IMHO. A good patch is a patch that doesn't need work when
updating the package to a new upstream version (ideally because it has
been applied upstream). Patching each individual problematic Makefile
line is NOT a good patch.
In this specific case, the tests' Makefile should guess by itself
whether it is being run from a source tree or not (e.g. by using a make
or environment variable that will be set when called from source tree).
Cheers,
--
Stéphane
Reply to: