Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags
On Wed, Nov 11, 2009 at 08:45:06PM +0100, Mehdi Dogguy wrote:
> The spaces around options are present on purpose to be *sure* that
> ocamlfind has to be called. You can relax the regexp and look only for
> the option name if you like it that way. It's a matter of taste. Adding
> a space at the beginning of the line should fix your problem.
IMO it is not a matter on taste, in the sense that: once you say to
_anyone_ to write command line options / flags in a file, that anyone
will most likely write them without leaving a heading white space. That
would make dh_ocamldoc unable to understand the flags, which in turn
would mean ocamlfind will not be detected appropriately (and hence
dh_ocamldoc will fail). That "wrong by default" behavior is what
justifies my important severity. YMMV.
The thing that the need to leave a heading whitespace is not documented,
obviously, make things worse.
Adding a space before the flags (which I had of course already
implemented) is not a fix, is a work around, the fix is changing the
regexp: it is rather easy (add a "beginning of word boundary" instead of
a space, before each flag) and I actually thought we've already agreed
on changing them.
Cheers.
--
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
zack@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..| . |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...........| ..: |.... Je dis tu à tous ceux que j'aime
Reply to: