Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags
Stefano Zacchiroli wrote:
>
> IMO it is not a matter on taste, in the sense that: once you say to
> _anyone_ to write command line options / flags in a file, that anyone
> will most likely write them without leaving a heading white space. That
> would make dh_ocamldoc unable to understand the flags, which in turn
> would mean ocamlfind will not be detected appropriately (and hence
> dh_ocamldoc will fail). That "wrong by default" behavior is what
> justifies my important severity. YMMV.
>
> The thing that the need to leave a heading whitespace is not documented,
Is it a matter of documentation then? :p
>
> the fix is changing the regexp: it is rather easy (add a "beginning
> of word boundary" instead of a space, before each flag)
Seems to be the good fix.
BTW, I don't remember having discussed this issue with you, ever.
Cheers,
--
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/
Reply to: