Bug#500869: Misc packaging fixes

[Loïc Minier <lool@dooz.org>]

On Sun, Nov 01, 2009, Stéphane Glondu wrote:
> Loïc Minier a écrit :
> >   * Don't overwrite DEB_DH_GENCONTROL_ARGS and use -u instead of -- to pass
> >     args to dpkg-gencontrol in a safer manner.
> 
> Can you tell how it is safer to use -u instead of --? I agree with the
> s/=/+=/, though.

 It's been a while, but I think I disliked the lack of readability and
 extensibility of the -- approach.

 Readability:

DEB_DH_GENCONTROL_ARGS+=-- -VF:OCamlABI="$(OCAMLABI)"

 This line is relatively hard to parse, compare to:
DEB_DH_GENCONTROL_ARGS += -u-VF:OCamlABI="$(OCAMLABI)"


 Extensibility: if you do "DEB_DH_GENCONTROL_ARGS += -- foo" at some
 place of rules, or in an include, appending DEB_DH_GENCONTROL_ARGS has
 a different meaning than the expected one.  However if you use -u, it's
 relatively consistent.

-- 
Loïc Minier