[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#541635: liquidsoap: incorrect dependencies on init script



Package:  liquidsoap
Version:  0.9.1-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency

Hi,

While examining some init scripts I found liquidsoap's to be missing some 
dependencies.

Since the binary lives in /usr it requires $remote_fs. And since it appears to 
open sockets (therefore requiring a network interface) it also requires 
$network. It might be possible that it needs other virtual facilities so 
please check [1].

http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
documents the LSB header format.  Some Debian notes are available at
[1] http://wiki.debian.org/LSBInitScripts

Without those changes the init.d will start too early in the boot sequence on 
some systems.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
diff -urpN liquidsoap-0.9.1-1.orig/debian/liquidsoap.init liquidsoap-0.9.1-1/debian/liquidsoap.init
--- liquidsoap-0.9.1-1.orig/debian/liquidsoap.init	2009-08-14 19:35:02.000000000 -0500
+++ liquidsoap-0.9.1-1/debian/liquidsoap.init	2009-08-14 19:37:43.490946973 -0500
@@ -1,8 +1,8 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          liquidsoap
-# Required-Start:
-# Required-Stop:
+# Required-Start:    $remote_fs $network
+# Required-Stop:     $remote_fs $network
 # Should-Start:
 # Should-Stop:
 # Default-Start:     2 3 4 5

Reply to: