[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#531360: libcamlpdf-ocaml-dev: unzip interface conflicts with extlib



Hi.

On 1 Jun 2009, at 19:59, Guillaume Yziquel wrote:

Romain Beauxis a écrit :
Ok, camlpdf is patched for *zip* not for *unzip*, which is not available in a seperate package. So what we have at first glance here is a module name clash: both extlib and camlpdf provide an interface for a module named Zip. It is not clear to me whether both modules provide the same functionalities (did not look at the code), but it is highly probable. I don't know what to do about this. Compiling camlpdf against the whole extlib does not seem a correct thing to do. Also there is no standalone unzip module available...
Romain

I've talked with upstream. Here is part of his answer:

I don't know much about packaging Ocaml modules, but I think the solution is for me to rename Unzip and Io to PDFUnzip and PDFUnzipIo in the next release. How does that sound?

Moreover, it seems that unzip provides some functionality that is not provided by extlib's unzip module. But this may also be functionalities that have been squashed out of camlpdf when requiring camlpdf to build against camlzip...

I guess that the simplest solution would be to let upstream change the module names upstream.

In the long run, the "right thing" would perhaps be to include an Unzip module in camlzip. This is, IMHO, where Unzip should belong.

Right, so:

Pdfcodec, in Ocaml, uses Zlib.uncompress / Zlib.compress

Pdfcodec in F sharp uses IO.read_all and Unzip.inflate

which means you can remove:

io.mli io.ml istring.mli istring.ml unzip.ml unzip.mli

from the makefile, since they won't be compiled by ocaml, only by F Sharp.

This compiles fine, at least with my latest build.

Cheers,

--
John Whitington
Coherent Graphics Ltd
http://www.coherentpdf.com/






Reply to: