[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#394543: marked as done (init script broken in various ways)

Your message dated Thu, 23 Nov 2006 22:02:09 +0000
with message-id <E1GnMe1-0005za-Uo@ries.debian.org>
and subject line Bug#394543: fixed in mldonkey 2.8.1-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: mldonkey-server
Version: 2.8.1-1
Severity: important

Basically, the stop action of the init script doesn't seem to want to
stop the daemon, or if it does, only after a long time after the script
finishes.  For example:

whitehawk:~# /etc/init.d/mldonkey-server start
Starting MLDonkey: mlnet.
whitehawk:~# ps ax | grep mlnet
 1827 ?        SN     0:00 /usr/bin/mldonkey_server --start --daemon --pidfile /var/run/mldonkey/mlnet.pid --chdir /var/lib/mldonkey --chgid mldonkey --umask 0002 --nice 10 --max-alive 48 --chuid mldonkey
 1832 ?        RN     0:01 /usr/bin/mlnet
 1834 ?        SN     0:00 /usr/bin/logger -t mlnet_error
 1836 ?        SN     0:00 /usr/bin/logger -t mlnet
 1838 pts/1    S+     0:00 grep mlnet
whitehawk:~# /etc/init.d/mldonkey-server stop
Stopping MLDonkey: mlnet.
whitehawk:~# ps ax | grep mlnet
 1827 ?        SN     0:00 /usr/bin/mldonkey_server --start --daemon --pidfile /var/run/mldonkey/mlnet.pid --chdir /var/lib/mldonkey --chgid mldonkey --umask 0002 --nice 10 --max-alive 48 --chuid mldonkey
 1832 ?        RN     0:05 /usr/bin/mlnet
 1834 ?        SN     0:00 /usr/bin/logger -t mlnet_error
 1836 ?        SN     0:00 /usr/bin/logger -t mlnet
 1846 pts/1    S+     0:00 grep mlnet
whitehawk:~# ps ax | grep mlnet
 1827 ?        SN     0:00 /usr/bin/mldonkey_server --start --daemon --pidfile /var/run/mldonkey/mlnet.pid --chdir /var/lib/mldonkey --chgid mldonkey --umask 0002 --nice 10 --max-alive 48 --chuid mldonkey
 1832 ?        RN     0:06 /usr/bin/mlnet
 1834 ?        SN     0:00 /usr/bin/logger -t mlnet_error
 1836 ?        SN     0:00 /usr/bin/logger -t mlnet
 1848 pts/1    S+     0:00 grep mlnet
whitehawk:~# ps ax | grep mlnet
 1827 ?        SN     0:00 /usr/bin/mldonkey_server --start --daemon --pidfile /var/run/mldonkey/mlnet.pid --chdir /var/lib/mldonkey --chgid mldonkey --umask 0002 --nice 10 --max-alive 48 --chuid mldonkey
 1832 ?        RN     0:07 /usr/bin/mlnet
 1834 ?        SN     0:00 /usr/bin/logger -t mlnet_error
 1836 ?        SN     0:00 /usr/bin/logger -t mlnet
 1850 pts/1    S+     0:00 grep mlnet
whitehawk:~# cat /var/run/mldonkey/mlnet.pid
1827
whitehawk:~# /etc/init.d/mldonkey-server stop
Stopping MLDonkey: mlnet.
whitehawk:~# cat /var/run/mldonkey/mlnet.pid
cat: /var/run/mldonkey/mlnet.pid: No such file or directory
whitehawk:~# ps ax | grep mlnet
 1832 ?        RNl    0:10 /usr/bin/mlnet
 1866 pts/1    S+     0:00 grep mlnet

It seems you need at least two tries with stop to make the mldonkey_server
process to go away, but this last mlnet process seems to want to take a very
long time before stopping.

The init script must be written so that before the stop action finishes,
all the relevant processes have actually disappeared.

This half-stopped process also confuses the start action:

whitehawk:~# /etc/init.d/mldonkey-server start
Starting MLDonkey: mlnet file[s] should no exist: /var/lib/mldonkey/mlnet.pid -- delete it first
whitehawk:~# ps ax | grep mlnet
 1832 ?        RNl    0:40 /usr/bin/mlnet
 1874 pts/1    S+     0:00 grep mlnet
whitehawk:~# /etc/init.d/mldonkey-server start
Starting MLDonkey: mlnet file[s] should no exist: /var/lib/mldonkey/mlnet.pid -- delete it first

This shouldn't happen: Either the process is already running, then there
should be no error, or the process is not running, then it should be
started.

Needless to say, the restart action is also broken completely as a
consequence of these problems.

--- End Message ---
--- Begin Message --- 
Source: mldonkey
Source-Version: 2.8.1-3

We believe that the bug you reported is fixed in the latest version of
mldonkey, which is due to be installed in the Debian FTP archive:

mldonkey-gui_2.8.1-3_i386.deb
  to pool/main/m/mldonkey/mldonkey-gui_2.8.1-3_i386.deb
mldonkey-server_2.8.1-3_i386.deb
  to pool/main/m/mldonkey/mldonkey-server_2.8.1-3_i386.deb
mldonkey_2.8.1-3.diff.gz
  to pool/main/m/mldonkey/mldonkey_2.8.1-3.diff.gz
mldonkey_2.8.1-3.dsc
  to pool/main/m/mldonkey/mldonkey_2.8.1-3.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 394543@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Mimram <smimram@debian.org> (supplier of updated mldonkey package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 23 Nov 2006 10:48:54 +0000
Source: mldonkey
Binary: mldonkey-gui mldonkey-server
Architecture: source i386
Version: 2.8.1-3
Distribution: unstable
Urgency: low
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Samuel Mimram <smimram@debian.org>
Description: 
 mldonkey-gui - Graphical frontend for mldonkey based on GTK
 mldonkey-server - Door to the 'donkey' network
Closes: 293016 341615 394543 396754 399962
Changes: 
 mldonkey (2.8.1-3) unstable; urgency=low
 .
   [ Samuel Mimram ]
   * Using start-stop-daemon to fully handle daemon, closes: #394543.
   * Not installing mldonkey-server anymore.
   * Using -pid option of mlnet to create the pidfile, closes: #341615.
   * Added mlguistarter.dpatch to print an error message when no argument is
     given to mlguistarter, closes: #396754.
   * Updated German debconf translation (thanks Matthias Julius),
     closes: #399962.
   * Added search.dpatch to support logical -not in searches, closes: #293016.
   * Update config.sub and config.guess in src/applets/kde/admin.
 .
   [ Sylvain Le Gall ]
   * Upgrade debhelper debian/compat to 5,
   * Replace dependency Source-Version by binary:Version,
   * Add versioned Build-Depends on dpkg-dev (>= 1.13.19),
   * Update my email to gildor@debian.org everywhere,
   * Rewrite debian/xml-man/*.xml, to have valid docbook file and use
     xinclude,
   * Upgrade docbook version to 4.4,
Files: 
 65135b50d2d826954b06ab9ec90d4969 1084 net optional mldonkey_2.8.1-3.dsc
 12ef7a9e694ea7f30dedaf7642890f72 133285 net optional mldonkey_2.8.1-3.diff.gz
 bdf23c542921711cf1ed9d53350448e5 2787558 net optional mldonkey-server_2.8.1-3_i386.deb
 64fc750233f06522c39f8dd5dc3eb23a 3264964 net optional mldonkey-gui_2.8.1-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFZhaxIae1O4AJae8RAjJYAJ90N103TMdKTk61tVMrQOIxhxygSQCeJaPB
Y5ivd17ljc223+MOisXakbk=
=4EUo
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: