Bug#378934: mldonkey-server: postinst breaks (dpkg failure) when mlnet fails to start

[Samuel Mimram <samuel.mimram@ens-lyon.org>]

Hi,

Eduard Bloch wrote:
> Package: mldonkey-server
> Version: 2.7.3-2
> Severity: grave
> 
> (Reading database ... 147973 files and directories currently installed.)
> Preparing to replace mldonkey-server 2.7.3-2 (using .../mldonkey-server_2.7.7-4_amd64.deb) ...
> Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' found running; none killed.
> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> dpkg: warning - old pre-removal script returned error exit status 1
> dpkg - trying script from the new package instead ...
> Stopping MLDonkey: mlnetNo process in pidfile `/var/run/mldonkey/mlnet.pid' found running; none killed.
> invoke-rc.d: initscript mldonkey-server, action "stop" failed.
> dpkg: error processing /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb (--unpack):
>  subprocess new pre-removal script returned error exit status 1
> Starting MLDonkey: mlnet configuration file prevent mlnet to be started (use force-start).
> Errors were encountered while processing:
>  /var/cache/apt/archives/mldonkey-server_2.7.7-4_amd64.deb
> E: Sub-process /usr/bin/dpkg returned an error code (1)

Unfortunately, this was a bug in the 2.7.3-2 version of the package
(which was removed from testing), see #338875, #363635 and #368118.

Please change the line 100 (in the stop case) of
/etc/init.d/mldonkey-server from

    start-stop-daemon --stop --pidfile $PIDFILE

to

    start-stop-daemon --stop --oknodo --pidfile $PIDFILE

(add the --oknodo) and the update should work. I'm sorry but I cannot
figure out an easy way to workaround this bug and make the package
upgrade properly. This is of course fixed in the current version of the
package.

IMHO this bug could be closed, what do you think?

Cheers,

Samuel.