Bug#265212: advi: FTBFS alpha: strange build failure

[Sven Luther <sven.luther@wanadoo.fr>]

On Thu, Aug 12, 2004 at 02:54:17PM +0200, Goswin von Brederlow wrote:
> Sven Luther <sven.luther@wanadoo.fr> writes:
> 
> > On Thu, Aug 12, 2004 at 12:15:36PM +0200, Julien Cristau wrote:
> >> On 12/08/2004-09:45, Goswin Brederlow wrote:
> >> > <snip the beginning of the build log>
> >> > if [ -x /usr/bin/ocamlopt.opt ]; then \
> >> > 	echo "Building the native code version with the native compilers"; \
> >> >         /usr/bin/make HAVE_OPT=".opt" opt; \
> >> > 	touch opt-built-stamp; \
> >> > else if [ -x /usr/bin/ocamlopt ]; then \
> >> > 	echo "Building the native code version"; \
> >> >         /usr/bin/make HAVE_OPT="" opt; \
> >> > 	touch opt-built-stamp; \
> >> > else \
> >> > 	echo "Building the bytecode version"; \
> >> >         /usr/bin/make byte; \
> >> > fi fi
> >> > Building the native code version with the native compilers
> >> 
> >> Ok, here is where it differs from the build log at 
> >> http://buildd.debian.org/fetch.php?&pkg=advi&ver=1.5.2%2Bcvs-2004.07.27-2&arch=i386&stamp=1091989825&file=log&as=raw.
> >> The last line of the Makefile is "include .depend", which normally 
> >> causes a regeneration of this file. However, here it what "info make" 
> >> say about included Makefiles:
> >> |   If the specified name does not start with a slash, and the file is
> >> |not found in the current directory, several other directories are
> >> |searched.  First, any directories you have specified with the `-I' or
> >> |`--include-dir' option are searched (*note Summary of Options: Options
> >> |Summary.).  Then the following directories (if they exist) are
> >> |searched, in this order: `PREFIX/include' (normally `/usr/local/include'
> >> |(1)) `/usr/gnu/include', `/usr/local/include', `/usr/include'.
> >> 
> >> My guess is that one of these files exist on your system, and the 
> >> ".depend" rule of advi's Makefile is never called. The safe way would be 
> >> to explicitely run make .depend before building advi.
> >
> > Goswin, can you test this by adding the $(MAKE) .depend below to the
> > debian/rules file ? 
> >
> > build: build-stamp
> > build-stamp: patch-stamp config.status
> >         dh_testdir
> >
> >         $(MAKE) .depend
> >         if [ -x /usr/bin/ocamlopt.opt ]; then \
> >                 echo "Building the native code version with the native compilers"; \
> >                 $(MAKE) HAVE_OPT=".opt" opt; \
> > 	...
> >
> > If you confirm this works, i will make a new upload of advi that fixes this
> > issue.
> >
> > Friendly,
> >
> > Sven Luther
> 
> I rerun debuild on the failed build and it worked. Then I requed the
> package on the same buildd to see if a pristine source would fail but
> that now build too.
> 
> Either the system had a hickup or something fixed itself while it
> installed and purged Build-Depends for packages inbetween.
> 
> So while I can't reproduce it and thus can't test if the "$(MAKE)
> .depend" makes a difference it still looks like its saver to add
> it. Can't hurd, can it?

Ok. I have added the patch to svn for a future upload, but will not make an
upload specialized for this.

Friendly,

Sven Luther