Re: Fwd: Cryptokit port to Numerix
On Wed, Dec 17, 2003 at 05:31:35PM -0800, Michael K. Edwards wrote:
> > --- orig/cryptokit.ml
> > +++ mod/cryptokit.ml
> > @@ -512,7 +512,7 @@
> > method put_substring src ofs len =
> > if len <= 0 then () else
> > - if used + len <= blocksize then begin
> > + if used + len < blocksize then begin
> > (* Just accumulate len characters in ibuf *)
> > String.blit src ofs ibuf used len;
> > used <- used + len
> This breaks "make test". Do you have a corresponding patch for test.ml?
Ugh. There is a bunch of stuff that assumes the broken behavior. This
is going to be a bit of work to figure out. I guess you should submit
it without the patch, since I don't think I'll get to it all that soon.
Perhaps it would be best to just open a bug that states that the ciphers
don't work as streams.
Hopefully, sometime, I'll get around to modifying the rest of the places
in the code where it assumes that the last block isn't output.