[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: camlimages currently unbuildable



Stefano Zacchiroli <zack@debian.org> writes:

> On Mon, Dec 16, 2002 at 11:13:10AM +0100, Sven Luther wrote:
>> Stefano, once you have done rebuilding, could you make avialable (or send me
>> via email) the new camlimage package ? I need it for building advi with
>> a few bugfixes.
>
> Camlimages is currently unbuildable, compilation fails with a parse
> error on an .h (/usr/include/tiffio.h), probably an undefined C type.
>
> I'm going to submit bugreport to the libtiff3g maintainer and wait for
> an answer.

Well, I've look a little to the code. The bug is in the camlimages
library in the tiffread.c and tiffwrite.c, when it define
_TIFF_DATA_TYPEDEFS_ but not uint8

I send a quick and dirty patch to solve this problem, may be there is
a better solution.

diff -ur camlimages-2.10.orig/tiff/tiffread.c camlimages-2.10/tiff/tiffread.c
--- camlimages-2.10.orig/tiff/tiffread.c	2002-04-22 15:27:39.000000000 +0200
+++ camlimages-2.10/tiff/tiffread.c	2002-12-16 17:20:23.000000000 +0100
@@ -37,15 +37,7 @@
 typedef	char int8;
 #endif
 
-#ifdef uint8
 typedef	unsigned char uint8;
-#endif
-#ifdef int16
-typedef	short int16;
-#endif
-#ifdef uint16
-typedef	unsigned short uint16;	/* sizeof (uint16) must == 2 */
-#endif
 
 #include <tiffio.h>
 
diff -ur camlimages-2.10.orig/tiff/tiffwrite.c camlimages-2.10/tiff/tiffwrite.c
--- camlimages-2.10.orig/tiff/tiffwrite.c	2001-06-15 14:43:13.000000000 +0200
+++ camlimages-2.10/tiff/tiffwrite.c	2002-12-16 17:21:30.000000000 +0100
@@ -34,15 +34,7 @@
 #else
 typedef	char int8;
 #endif
-#ifdef uint8
 typedef	unsigned char uint8;
-#endif
-#ifdef int16
-typedef	short int16;
-#endif
-#ifdef uint16
-typedef	unsigned short uint16;	/* sizeof (uint16) must == 2 */
-#endif
 
 #include <tiffio.h>
 

-- 
Rémi Vanicat
vanicat@labri.u-bordeaux.fr
http://dept-info.labri.u-bordeaux.fr/~vanicat

Reply to: