[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1121523: audacity still FTCBFS: two more reasons



Source: audacity
Version: 3.7.5+dfsg-3
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

Hi,

thanks for quickly applying my earlier patch. Unfortunately, there are
two more problems left.

In my previous patch, I added libportmidi-dev:native to Build-Depends
for the native pass. When you applied it, you dropped the host's
libportmidi-dev. However, that library is really needed for both
architectures. Since your last upload, it is the cross compilation pass
that fails to configure.

Previously, I had tested building the package for armhf and that works
(with libportmidi-dev), but when my CI retried it for arm64 today, it
ran into an architecture-specific problem. We have unique compiler flags
such as -mbranch-protection=standard there. These are communicated via
the environment and thus inherited to the native build pass. The native
amd64 compiler is not very happy encountering those flags. We need to
recompute them for the build architecture. The easiest way of doing this
is using debhelper's --reload-all-buildenv-variables.

I'm attaching a patch fixing both of these problems. Please consider
applying it as well.

Helmut
diff -Nru audacity-3.7.5+dfsg/debian/changelog audacity-3.7.5+dfsg/debian/changelog
--- audacity-3.7.5+dfsg/debian/changelog	2025-11-25 17:55:07.000000000 +0100
+++ audacity-3.7.5+dfsg/debian/changelog	2025-11-26 10:20:50.000000000 +0100
@@ -1,3 +1,12 @@
+audacity (3.7.5+dfsg-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Add back the host's libportmidi-dev to Build-Depends.
+    + Recompute compiler flags for the native build pass for arm64.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 26 Nov 2025 10:20:50 +0100
+
 audacity (3.7.5+dfsg-3) unstable; urgency=medium
 
   [ Helmut Grohne ]
diff -Nru audacity-3.7.5+dfsg/debian/control audacity-3.7.5+dfsg/debian/control
--- audacity-3.7.5+dfsg/debian/control	2025-11-24 16:00:07.000000000 +0100
+++ audacity-3.7.5+dfsg/debian/control	2025-11-26 10:20:50.000000000 +0100
@@ -28,6 +28,7 @@
                libmpg123-dev,
                libogg-dev,
 	       libopusfile-dev,
+               libportmidi-dev,
                libportmidi-dev:native,
                libportsmf-dev,
                libsbsms-dev (>= 2.2.0~),
diff -Nru audacity-3.7.5+dfsg/debian/rules audacity-3.7.5+dfsg/debian/rules
--- audacity-3.7.5+dfsg/debian/rules	2025-11-24 15:59:34.000000000 +0100
+++ audacity-3.7.5+dfsg/debian/rules	2025-11-26 10:20:50.000000000 +0100
@@ -61,7 +61,9 @@
 
 override_dh_auto_configure:
 ifneq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
-	cmake -B obj-$(DEB_BUILD_GNU_TYPE) -DCMAKE_VERBOSE_MAKEFILE=ON $(CMAKE_FLAGS) $(DISABLE_LIBRARIES)
+	dpkg-architecture -a$(DEB_BUILD_ARCH) -f -c \
+		dh_auto_configure --reload-all-buildenv-variables --builddirectory=obj-$(DEB_BUILD_GNU_TYPE) -- \
+		$(CMAKE_FLAGS) $(DISABLE_LIBRARIES)
 	cmake --build obj-$(DEB_BUILD_GNU_TYPE) --target image-compiler
 endif
 	WX_CONFIG=/usr/lib/$(DEB_HOST_GNU_TYPE)/wx/config/gtk3-unicode-3.2 dh_auto_configure -- $(CMAKE_FLAGS) $(CROSS_CMAKE_FLAGS)

Reply to: