[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1117103: playerctl: Please don't build-depend on dbus-x11 or rely on dbus-launch



Source: playerctl
Version: 2.4.1-3
Severity: normal
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

playerctl Build-Depends on dbus-x11, presumably because 
test/conftest.py explicitly invokes dbus-launch.

dbus-launch is poorly-understood legacy code and is best avoided. If 
this test-case wants to start a temporary dbus-daemon, connect to it, do 
some testing and then terminate it, it is better to invoke dbus-daemon 
directly (which only requires the dbus-daemon package), using its 
--print-address and --print-pid options: for example, search for 
--print-pid in 
https://salsa.debian.org/gnome-team/tinysparql/-/blob/debian/trixie/tests/functional-tests/dbusdaemon.py?ref_type=heads 
for an example of doing this from Python code.

Thanks,
    smcv


Reply to: