[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1094467: marked as done (audacity: build with vst3sdk support)

Your message dated Sun, 28 Sep 2025 18:19:22 +0000
with message-id <E1v2vzW-00BXiP-0b@fasolo.debian.org>
and subject line Bug#1094467: fixed in audacity 3.7.5+dfsg-2
has caused the Debian Bug report #1094467,
regarding audacity: build with vst3sdk support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1094467: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1094467
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: audacity
Version: 3.7.1+dfsg-1
Severity: wishlist
Tags: patch

Dear Maintainer,
Please consider building audacity with vst3sdk support. vst3sdk is packaged in Debian as libvst3sdk-dev. The attached debdiff enables vst3sdk support in audacity and builds successfully at least on amd64.
There is, however, a concern about architecture support. libvst3sdk-dev is not provided on i386 and riscv64, thus ideally on these architectures audacity should build without vst3sdk. I did not implement conditional building in the attached debdiff yet.
If convenient, my changes can also be viewed on git branch on salsa: https://salsa.debian.org/merkys/audacity/-/tree/with-vst3sdk 

Best wishes,
Andrius
diff -Nru audacity-3.7.1+dfsg/debian/changelog audacity-3.7.1+dfsg/debian/changelog
--- audacity-3.7.1+dfsg/debian/changelog	2024-12-31 13:53:08.000000000 +0000
+++ audacity-3.7.1+dfsg/debian/changelog	2025-01-28 11:02:59.000000000 +0000
@@ -1,3 +1,9 @@
+audacity (3.7.1+dfsg-2) UNRELEASED; urgency=medium
+
+  * Build with vst3sdk support.
+
+ -- Andrius Merkys <merkys@debian.org>  Tue, 28 Jan 2025 11:02:59 +0000
+
 audacity (3.7.1+dfsg-1) unstable; urgency=medium
 
   * New upstream version 3.7.1+dfsg
diff -Nru audacity-3.7.1+dfsg/debian/control audacity-3.7.1+dfsg/debian/control
--- audacity-3.7.1+dfsg/debian/control	2024-11-09 20:36:13.000000000 +0000
+++ audacity-3.7.1+dfsg/debian/control	2025-01-28 10:03:45.000000000 +0000
@@ -42,6 +42,7 @@
                libsuil-dev,
                libtwolame-dev,
                libvorbis-dev,
+               libvst3sdk-dev,
                libwavpack-dev (>= 5.2.0),
                libwxgtk3.2-dev,
                libwxgtk3.2-dev:native,
diff -Nru audacity-3.7.1+dfsg/debian/patches/adjust-vst3sdk-paths.patch audacity-3.7.1+dfsg/debian/patches/adjust-vst3sdk-paths.patch
--- audacity-3.7.1+dfsg/debian/patches/adjust-vst3sdk-paths.patch	1970-01-01 00:00:00.000000000 +0000
+++ audacity-3.7.1+dfsg/debian/patches/adjust-vst3sdk-paths.patch	2025-01-28 10:03:45.000000000 +0000
@@ -0,0 +1,93 @@
+--- a/cmake-proxies/cmake-modules/Findvst3sdk.cmake
++++ b/cmake-proxies/cmake-modules/Findvst3sdk.cmake
+@@ -3,82 +3,29 @@
+ ]]
+ 
+ if( NOT vst3sdk_FOUND )
+-   if( DEFINED ENV{VST3_SDK_DIR} )
+-      set( vst3sdk_DIR $ENV{VST3_SDK_DIR} )
+-   elseif( DEFINED ENV{VST3SDK_PATH} )
+-      set( vst3sdk_DIR $ENV{VST3SDK_PATH} )
+-   elseif( DEFINED ENV{VST3SDK} )
+-      set( vst3sdk_DIR $ENV{VST3SDK} )
+-   else()
+-      set( vst3sdk_DIR ${CMAKE_SOURCE_DIR}/vst3sdk )
+-   endif()
+-
+-   if( NOT EXISTS ${vst3sdk_DIR} )
+-      message( STATUS "VST3SDK not found. Please set VST3SDK_DIR to the path to the vst3sdk directory." )
+-      return()
+-   endif()
+-
+-   set( vst3sdk_BUILD ${CMAKE_BINARY_DIR}/vst3sdk )
+-
+-   message( STATUS "VST3SDK_DIR: ${vst3sdk_DIR}" )
+-   message( STATUS "Building SDK in ${vst3sdk_BUILD}" )
+-
+-   execute_process(COMMAND
+-      ${CMAKE_COMMAND}
+-         -G ${CMAKE_GENERATOR}
+-         -S ${vst3sdk_DIR}
+-         -B ${vst3sdk_BUILD}
+-         -D CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
+-         -D SMTG_ENABLE_VST3_HOSTING_EXAMPLES=OFF
+-         -D SMTG_ENABLE_VST3_PLUGIN_EXAMPLES=OFF
+-         -D SMTG_ENABLE_VSTGUI_SUPPORT=OFF
+-         -D SMTG_CREATE_BUNDLE_FOR_WINDOWS=Off
+-         -D SMTG_MYPLUGINS_SRC_PATH=""
+-         -D SMTG_RUN_VST_VALIDATOR=Off
+-
+-      RESULT_VARIABLE vst3sdk_configure_result
+-   )
+-
+-   if( vst3sdk_configure_result )
+-      message( FATAL_ERROR "Failed to configure VST3SDK" )
+-   endif()
+-
+-   execute_process(COMMAND
+-      ${CMAKE_COMMAND}
+-         --build ${vst3sdk_BUILD}
+-         --config ${CMAKE_BUILD_TYPE}
+-         --parallel
+-
+-      RESULT_VARIABLE vst3sdk_build_result
+-   )
+-
+-   if( vst3sdk_build_result )
+-      message( FATAL_ERROR "Failed to build VST3SDK" )
+-   endif()
+-
+    add_library(vst3sdk::base STATIC IMPORTED GLOBAL)
+    add_library(vst3sdk::pluginterfaces STATIC IMPORTED GLOBAL)
+    add_library(vst3sdk::sdk_hosting STATIC IMPORTED GLOBAL)
+    add_library(vst3sdk::sdk_common STATIC IMPORTED GLOBAL)
+ 
+    set_target_properties(vst3sdk::base PROPERTIES
+-      IMPORTED_LOCATION ${vst3sdk_BUILD}/lib/${CMAKE_BUILD_TYPE}/${CMAKE_STATIC_LIBRARY_PREFIX}base${CMAKE_STATIC_LIBRARY_SUFFIX}
+-      INTERFACE_INCLUDE_DIRECTORIES ${vst3sdk_DIR}
++      IMPORTED_LOCATION /usr/lib/${CMAKE_DEB_HOST_MULTIARCH}/vst3sdk/${CMAKE_STATIC_LIBRARY_PREFIX}base${CMAKE_STATIC_LIBRARY_SUFFIX}
++      INTERFACE_INCLUDE_DIRECTORIES /usr/include/vst3sdk
+    )
+ 
+    set_target_properties(vst3sdk::pluginterfaces PROPERTIES
+-      IMPORTED_LOCATION ${vst3sdk_BUILD}/lib/${CMAKE_BUILD_TYPE}/${CMAKE_STATIC_LIBRARY_PREFIX}pluginterfaces${CMAKE_STATIC_LIBRARY_SUFFIX}
+-      INTERFACE_INCLUDE_DIRECTORIES ${vst3sdk_DIR}
++      IMPORTED_LOCATION /usr/lib/${CMAKE_DEB_HOST_MULTIARCH}/vst3sdk/${CMAKE_STATIC_LIBRARY_PREFIX}pluginterfaces${CMAKE_STATIC_LIBRARY_SUFFIX}
++      INTERFACE_INCLUDE_DIRECTORIES /usr/include/vst3sdk
+    )
+ 
+    set_target_properties(vst3sdk::sdk_hosting PROPERTIES
+-      IMPORTED_LOCATION ${vst3sdk_BUILD}/lib/${CMAKE_BUILD_TYPE}/${CMAKE_STATIC_LIBRARY_PREFIX}sdk_hosting${CMAKE_STATIC_LIBRARY_SUFFIX}
+-      INTERFACE_INCLUDE_DIRECTORIES ${vst3sdk_DIR}
++      IMPORTED_LOCATION /usr/lib/${CMAKE_DEB_HOST_MULTIARCH}/vst3sdk/${CMAKE_STATIC_LIBRARY_PREFIX}sdk_hosting${CMAKE_STATIC_LIBRARY_SUFFIX}
++      INTERFACE_INCLUDE_DIRECTORIES /usr/include/vst3sdk
+    )
+ 
+    set_target_properties(vst3sdk::sdk_common PROPERTIES
+-      IMPORTED_LOCATION ${vst3sdk_BUILD}/lib/${CMAKE_BUILD_TYPE}/${CMAKE_STATIC_LIBRARY_PREFIX}sdk_common${CMAKE_STATIC_LIBRARY_SUFFIX}
+-      INTERFACE_INCLUDE_DIRECTORIES ${vst3sdk_DIR}
++      IMPORTED_LOCATION /usr/lib/${CMAKE_DEB_HOST_MULTIARCH}/vst3sdk/${CMAKE_STATIC_LIBRARY_PREFIX}sdk_common${CMAKE_STATIC_LIBRARY_SUFFIX}
++      INTERFACE_INCLUDE_DIRECTORIES /usr/include/vst3sdk
+    )
+ 
+    find_package(X11 REQUIRED)
diff -Nru audacity-3.7.1+dfsg/debian/patches/series audacity-3.7.1+dfsg/debian/patches/series
--- audacity-3.7.1+dfsg/debian/patches/series	2024-11-09 20:37:00.000000000 +0000
+++ audacity-3.7.1+dfsg/debian/patches/series	2025-01-28 10:03:45.000000000 +0000
@@ -1,3 +1,4 @@
 Fix-rpath-for-private-libraries-on-Linux.patch
 Fix-setting-audacity_use_midi-off.patch
 Drop-UBUNTU_MENUPROXY-0-workaround.patch
+adjust-vst3sdk-paths.patch
diff -Nru audacity-3.7.1+dfsg/debian/rules audacity-3.7.1+dfsg/debian/rules
--- audacity-3.7.1+dfsg/debian/rules	2024-04-28 16:41:29.000000000 +0000
+++ audacity-3.7.1+dfsg/debian/rules	2025-01-28 10:03:45.000000000 +0000
@@ -10,10 +10,11 @@
 	-DCMAKE_INSTALL_LIBDIR=lib \
 	-Daudacity_conan_enabled=Off \
 	-Daudacity_has_networking=Off \
-	-Daudacity_has_vst3=Off \
 	-Daudacity_lib_preference=system \
 	-Daudacity_use_ffmpeg=loaded \
+	-Daudacity_use_vst3sdk=system \
 	-DwxBUILD_TOOLKIT=gtk3 \
+	-DCMAKE_DEB_HOST_MULTIARCH=$(DEB_HOST_MULTIARCH) \
 	$(NULL)
 
 ifeq (,$(findstring ~,$(DEB_VERSION_UPSTREAM)))

--- End Message ---
--- Begin Message --- 
Source: audacity
Source-Version: 3.7.5+dfsg-2
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
audacity, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1094467@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated audacity package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 28 Sep 2025 19:59:03 +0200
Source: audacity
Architecture: source
Version: 3.7.5+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 1094467
Changes:
 audacity (3.7.5+dfsg-2) unstable; urgency=medium
 .
   * Build with vst3sdk support. Thanks to Andrius Merkys (Closes: #1094467)
Checksums-Sha1:
 18cb456b676de6cccc9076300fc2f9081637852b 3085 audacity_3.7.5+dfsg-2.dsc
 d35089b1a1878a5e5ce90c84fded55b15997174e 30624 audacity_3.7.5+dfsg-2.debian.tar.xz
 38d83cabb362413853ac54148d0e72b798a58932 6446 audacity_3.7.5+dfsg-2_source.buildinfo
Checksums-Sha256:
 204f76b13618c6d710cfbea89b7cc45724d837d0c10073e63cde63f41b2af0e2 3085 audacity_3.7.5+dfsg-2.dsc
 3a9712eac808f04f1f356039cbd26fa2d46649ce381cb91c79e2d199fe10d2c5 30624 audacity_3.7.5+dfsg-2.debian.tar.xz
 f9dc3aa718df43f4010ddd40b195d6b665dfda1a52c5d02f85c0c0dd49ba13fd 6446 audacity_3.7.5+dfsg-2_source.buildinfo
Files:
 d1a2a8c851543f2a528b75dbf18948bd 3085 sound optional audacity_3.7.5+dfsg-2.dsc
 f6924231904d934966be8335e324fc55 30624 sound optional audacity_3.7.5+dfsg-2.debian.tar.xz
 e1ed1eb5ad0b5cbad5e8a421adc62c6b 6446 sound optional audacity_3.7.5+dfsg-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

wsG7BAEBCgBvBYJo2XeXCRBjTqVdkCuYNkcUAAAAAAAeACBzYWx0QG5vdGF0aW9u
cy5zZXF1b2lhLXBncC5vcmcwxJQRsSulFjWFvnVsn7nb4No97YIK6NzlvOU1MuCf
DBYhBDy3wwKvtX5hqMYX3WNOpV2QK5g2AABLOhAAnfQUz/Ux26K9++pwRsdscoXL
6ClKtKtQ/+Jirm1Nv6hLHNxuFhtNLKvK+h8ZT0SWzyyvmQ70gVejB9Y/2+4+AY3w
+LULI2MfPxKioraPinPPdKc4uviUBbE1q9b7t9Uf2VJe+tN7rROKKAauc1N2LJLL
mTXNd4JAqGOe6l0mnc65qHne3VtXfeU9ci11EMhIsMb2OUCh8uREx+Yufbvag7OI
MUfqRNK7RjisE23NEsYPFwMEc1B9G9yNvnUbHrtlIJCNbQIoqjWg+r3yP+G7Bxk0
fkKjMOtOhOmIHYpTHFxTD+CenCXFXBTlpsHt9fykksNgdrAbaoPJ/bJ5T0bP6I5z
ZECHBnwr+7RUVew0c5A2A+ZPtsppqK7oGmJfJqx7v4c5GvB+WPJq+K8n3TruA8hI
Ess7kuaLRlaVL4p8vJt64c85RZ7LUML+g4mVeq6uz1ILuy43P6eEdv+JDA7F7noY
8LHMyYDql0a/c/s5xFAF4WmLQHj8JxGMon+fd5sJRa7NC63gTYgbDtAn3+V/ZtsT
y1FnpgECfS36zQhL8vSdQ4yi2otg8765fu8MImAdepCMKRVmLx7csrEkTWXUKuXR
uQbKnbkA2Eb4k99PCu4+mN/plVa1sSnYqDRBCV4phhKUbsh+sqk1LRJf06Az8xD1
MC/Md1HB4vBoJOEnzjQ=
=Ygei
-----END PGP SIGNATURE-----

Attachment: pgpKZ5vPagDWm.pgp
Description: PGP signature


--- End Message ---
Reply to: