Bug#1115167: libpisp: FTBFS: ../src/helpers/media_device.cpp:251:14: error: ignoring return value of ‘int lockf(int, int, __off64_t)’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
Source: libpisp
Version: 1.2.1-2
Severity: important
Tags: ftbfs forky sid
Justification: fails to build from source
User: debian-glibc@lists.debian.org
Usertags: glibc-2.42
Dear maintainer,
During a rebuild of all packages in unstable with glibc 2.42 from
experimental, your package failed to build. Below you will find how the
build ends. If required, the full build log is available here:
https://people.debian.org/~aurel32/glibc-2.42/
The build failure is due to a missing check of the result of the call to
lockf(), so there is no guarantee that the file is correctly locked,
basically making this call useless.
About the archive rebuild: The build was made on virtual machines from
AWS, using sbuild, a reduced chroot with only build-essential packages
and glibc 2.42 from experimental.
Regards
Aurelien
--------------------------------------------------------------------------------
[...]
[21/25] c++ -Isrc/libpisp.so.1.2.1.p -Isrc -I../src -Isrc/libpisp -I../src/libpisp -I/usr/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -DPISP_LOGGING_ENABLE=1 -DBOOST_BIND_GLOBAL_PLACEHOLDERS -Wno-address-of-packed-member -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DBOOST_LOG_DYN_LINK=1 -DBOOST_LOG_SETUP_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_USE_DLL=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_ALL_NO_LIB -MD -MQ src/libpisp.so.1.2.1.p/helpers_backend_device.cpp.o -MF src/libpisp.so.1.2.1.p/helpers_backend_device.cpp.o.d -o src/libpisp.so.1.2.1.p/helpers_backend_device.cpp.o -c ../src/helpers/backend_device.cpp
[22/25] c++ -Isrc/libpisp.so.1.2.1.p -Isrc -I../src -Isrc/libpisp -I../src/libpisp -I/usr/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -DPISP_LOGGING_ENABLE=1 -DBOOST_BIND_GLOBAL_PLACEHOLDERS -Wno-address-of-packed-member -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DBOOST_LOG_DYN_LINK=1 -DBOOST_LOG_SETUP_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_USE_DLL=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_ALL_NO_LIB -MD -MQ src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -MF src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o.d -o src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -c ../src/helpers/media_device.cpp
FAILED: src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o
c++ -Isrc/libpisp.so.1.2.1.p -Isrc -I../src -Isrc/libpisp -I../src/libpisp -I/usr/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -DPISP_LOGGING_ENABLE=1 -DBOOST_BIND_GLOBAL_PLACEHOLDERS -Wno-address-of-packed-member -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DBOOST_LOG_DYN_LINK=1 -DBOOST_LOG_SETUP_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_USE_DLL=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_ALL_NO_LIB -MD -MQ src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -MF src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o.d -o src/libpisp.so.1.2.1.p/helpers_media_device.cpp.o -c ../src/helpers/media_device.cpp
../src/helpers/media_device.cpp: In member function ‘std::map<std::__cxx11::basic_string<char>, libpisp::helpers::DeviceFd>::iterator libpisp::helpers::MediaDevice::unlock(const std::string&)’:
../src/helpers/media_device.cpp:251:14: error: ignoring return value of ‘int lockf(int, int, __off64_t)’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
251 | lockf(it->second.Get(), F_ULOCK, 0);
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[23/25] c++ -Isrc/libpisp.so.1.2.1.p -Isrc -I../src -Isrc/libpisp -I../src/libpisp -I/usr/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -DPISP_LOGGING_ENABLE=1 -DBOOST_BIND_GLOBAL_PLACEHOLDERS -Wno-address-of-packed-member -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -DBOOST_LOG_DYN_LINK=1 -DBOOST_LOG_SETUP_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_USE_DLL=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_ALL_NO_LIB -MD -MQ src/libpisp.so.1.2.1.p/helpers_v4l2_device.cpp.o -MF src/libpisp.so.1.2.1.p/helpers_v4l2_device.cpp.o.d -o src/libpisp.so.1.2.1.p/helpers_v4l2_device.cpp.o -c ../src/helpers/v4l2_device.cpp
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j2 -v returned exit code 1
make: *** [debian/rules:6: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Reply to: