Bug#1110989: libigloo-dev: Wrong header guard in /usr/include/igloo/sp.h
Package: libigloo-dev
Version: 0.9.2-1.1+b1
Severity: important
Dear Maintainer,
* What led up to the situation?
Trying to compile icecast2 from latest Xiph sources
* What exactly did you do (or not do) that was effective (or
ineffective)?
Running make
* What was the outcome of this action?
event_stream.c: In function ‘event_stream_add_client_inner’:
event_stream.c:213:9: error: implicit declaration of function ‘igloo_cs_to_bool’ [-Wimplicit-function-declaration]
213 | igloo_cs_to_bool(request_global, &(state->events_global));
| ^~~~~~~~~~~~~~~~
event_stream.c: In function ‘event_stream_event_render’:
event_stream.c:545:25: error: implicit declaration of function ‘igloo_cs_to_upper’; did you mean ‘igloo_ro_to_type’? [-Wimplicit-function-declaration]
545 | igloo_cs_to_upper(name);
| ^~~~~~~~~~~~~~~~~
| igloo_ro_to_type
* What outcome did you expect instead?
Successfull compilation
Turns out the reason for this i that the content of both /usr/include/igloo/cs.h and /usr/include/igloo/sp.h are included in #ifndef _LIBIGLOO__CS_H_ blocks and also #define _LIBIGLOO__CS_H_ within that block which means that You only get the definitions from one or the other, depending on the #include order in the source code.
_LIBIGLOO__CS_H_ should be changed to _LIBIGLOO__SP_H_ in /usr/include/igloo/sp.h (fixed upstream about 1,5 years ago).
-- System Information:
Debian Release: 13.0
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 6.12.38+deb13-amd64 (SMP w/1 CPU thread; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages libigloo-dev depends on:
ii libigloo0t64 0.9.2-1.1+b1
libigloo-dev recommends no packages.
libigloo-dev suggests no packages.
-- no debconf information
Reply to: