[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059253: marked as done (The speexdsp package has no autopkgtest)

Your message dated Sat, 25 Jan 2025 16:07:01 +0000
with message-id <E1tbigX-005ofT-Ho@fasolo.debian.org>
and subject line Bug#1059253: fixed in speexdsp 1.2.1-3
has caused the Debian Bug report #1059253,
regarding The speexdsp package has no autopkgtest
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1059253: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059253
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: speexdsp
Version: 1.2.1-1
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
I'm working on getting speexdsp promoted for Ubuntu (Depends of roc-toolkit which is a new depends of pipewire), one of the requirements is to have tests. Upstream doesn't provide a testsuite but having an small 'build test' autopkg would be better than noticing, I'm adding a patch that adds one. It at least ensure that the corresponding header and .pc are installed and that the dev binary isn't missing a depends 

Cheers,
Sébastien

diff -Nru speexdsp-1.2.1/debian/changelog speexdsp-1.2.1/debian/changelog
--- speexdsp-1.2.1/debian/changelog	2022-09-17 19:48:41.000000000 +0200
+++ speexdsp-1.2.1/debian/changelog	2023-12-21 15:43:07.000000000 +0100
@@ -1,3 +1,10 @@
+speexdsp (1.2.1-2) UNRELEASED; urgency=medium
+
+  * Add a simple build autopkgtest for the library, it does ensure at least
+    that the needed files are installed and the dev depends correct. 
+
+ -- Sebastien Bacher <seb128@ubuntu.com>  Thu, 21 Dec 2023 15:43:07 +0100
+
 speexdsp (1.2.1-1) unstable; urgency=medium
 
   * New upstream release. (Closes: #1014555)
diff -Nru speexdsp-1.2.1/debian/control speexdsp-1.2.1/debian/control
--- speexdsp-1.2.1/debian/control	2022-04-02 03:48:08.000000000 +0200
+++ speexdsp-1.2.1/debian/control	2023-12-21 15:43:07.000000000 +0100
@@ -1,7 +1,8 @@
 Source: speexdsp
 Priority: optional
 Section: sound
-Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
+XSBC-Original-Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
 Uploaders:
  Boyuan Yang <byang@debian.org>,
 Build-Depends:
diff -Nru speexdsp-1.2.1/debian/tests/build speexdsp-1.2.1/debian/tests/build
--- speexdsp-1.2.1/debian/tests/build	1970-01-01 01:00:00.000000000 +0100
+++ speexdsp-1.2.1/debian/tests/build	2023-12-21 15:43:07.000000000 +0100
@@ -0,0 +1,32 @@
+#!/bin/sh
+# autopkgtest check: Build and run a program against libspeexdsp, 
+# to verify that the headers and pkg-config file are installed correctly
+
+set -e
+
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+    CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+    CROSS_COMPILE=
+fi
+
+cat <<EOF > libspeexdsp_test.c
+#include <stddef.h>
+#include <speex/speex_resampler.h>
+
+int main(void)
+{
+  SpeexResamplerState *st = speex_resampler_init(1, 48000, 48000, 4, NULL);
+
+  return 0;
+}
+EOF
+
+# deliberately word-splitting pkg-config output:
+# shellcheck disable=SC2046
+"${CROSS_COMPILE}gcc" -o libspeexdsp_test libspeexdsp_test.c \
+$("${CROSS_COMPILE}pkg-config" --cflags --libs speexdsp)
+echo "build: OK"
+[ -x libspeexdsp_test ]
+./libspeexdsp_test
+echo "run: OK"
diff -Nru speexdsp-1.2.1/debian/tests/control speexdsp-1.2.1/debian/tests/control
--- speexdsp-1.2.1/debian/tests/control	1970-01-01 01:00:00.000000000 +0100
+++ speexdsp-1.2.1/debian/tests/control	2023-12-21 15:43:07.000000000 +0100
@@ -0,0 +1,3 @@
+Tests: build
+Depends: build-essential, pkg-config, libspeexdsp-dev
+Restrictions: allow-stderr superficial

--- End Message ---
--- Begin Message --- 
Source: speexdsp
Source-Version: 1.2.1-3
Done: Dylan Aïssi <daissi@debian.org>

We believe that the bug you reported is fixed in the latest version of
speexdsp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059253@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <daissi@debian.org> (supplier of updated speexdsp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 25 Jan 2025 16:37:48 +0100
Source: speexdsp
Architecture: source
Version: 1.2.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dylan Aïssi <daissi@debian.org>
Closes: 1059253
Changes:
 speexdsp (1.2.1-3) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Sebastien Bacher ]
   * Add a simple build autopkgtest for the library, it does ensure at least
     that the needed files are installed and the dev depends correct.
     (Closes: #1059253)
 .
   [ Dylan Aïssi ]
   * Add Build-Depends-Package field in symbols file.
   * Add Rules-Requires-Root: no
Checksums-Sha1:
 38ea94d12868b15c16b868fc8f6e2d5405c87f25 2257 speexdsp_1.2.1-3.dsc
 ee7269a7079382807c1d2d6b60b660d7fb944a9f 5012 speexdsp_1.2.1-3.debian.tar.xz
 f2825d68e5f46b33613964fc29b2d5f5672a23a1 6590 speexdsp_1.2.1-3_amd64.buildinfo
Checksums-Sha256:
 a9984758365f342ccda2d316849531c6885d376a2902a86add488986b5283ca4 2257 speexdsp_1.2.1-3.dsc
 a566b3d9e7a8f46e39881eb5e599e93010c3ce3717edda4025c313e1fc05e1bf 5012 speexdsp_1.2.1-3.debian.tar.xz
 b23dc24cd33f88e0f33370b9c6798e97ca7301223b0256952fdc8fff93097e2b 6590 speexdsp_1.2.1-3_amd64.buildinfo
Files:
 518ec4e5933bf78702b2098079adcce4 2257 sound optional speexdsp_1.2.1-3.dsc
 be5ad929c23e6ee5d0e5725c476268ef 5012 sound optional speexdsp_1.2.1-3.debian.tar.xz
 5ba6c2722d2cf6d075cce224f73489bf 6590 sound optional speexdsp_1.2.1-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmeVBnYACgkQYS7xYT4F
D1SbZA//fy1Lu8Kq5gvwntrv0em8Lw4Frf9Vr0Cu0G25oAYkRjEmMHAlPRr40otc
LQ5fFRL45WZWVnRcdULyHhCCj3pxLpXcMS4X5elYD203gWPkhBcjWSemyI9wDdGe
c58iFeNl/7XuC1+jRPw87hwc/S+Gtxnk93yBZGfL/vE/1/XJJJbJ12hjXos7VuxK
gnXIM3lEEDMUWuJBn0z1erOAEZz/xLagUf52lxrimr0zs2JBEdxux/mARvuZ2jF+
zxTFXfdqn+ySX+uUXZVydQv27oWjG8lwI+yEhU66Z+Nb109+lvcA8+jpDDaRWlwX
HC8rWq0qW/nAodIbDIlYHZ4BQKkPj4I0rpe2eGJTZ5dJa1PyYidoo25TIfovZg5c
7uNLPjYFi4WhTIA5vqPm+re8tMdtrSIWZT2DfVLK6mIkG0MmkIVgOsIMMlz+Xjxq
Mf3hAKMRe6mUKZUwtZ5CQIYIkTM9ytcDCbzv9c9jG1a+6s3RlKtJ0hjUGeM6PaHj
HdUv5BbXD3nPC3a6lGDyBwf4EJf4uxg4joAGbiyEZpAjjEQQZZ5q32HHtNBsNbVy
kpaqYEHoGoaGd3BcRx3b36lickIKymRjSEJN1/c5ZTXZ/g6YiKxtl3WBoZlpVCd8
z3JDBxYmbtdHCbj9vqQWaES3PU07275zKZnGYaFkTPiAdTekc6g=
=AZy2
-----END PGP SIGNATURE-----

Attachment: pgptCQpf4EZob.pgp
Description: PGP signature


--- End Message ---
Reply to: