[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1071027: marked as done (hdrmerge: FTBFS with exiv2 0.28)

Your message dated Fri, 13 Sep 2024 21:20:28 +0000
with message-id <E1spDiO-001n7q-Fq@fasolo.debian.org>
and subject line Bug#1071027: fixed in hdrmerge 0.5+git20200117-4.1
has caused the Debian Bug report #1071027,
regarding hdrmerge: FTBFS with exiv2 0.28
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1071027: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071027
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: hdrmerge
Version: 0.5+git20200117-3.1
Severity: important
Tags: patch ftbfs
X-Debbugs-Cc: gurkan@phys.ethz.ch
Control: forwarded -1 https://github.com/jcelaya/hdrmerge/pull/222

Hi,

hdrmerge fails to build with the new stable series of the Exiv2 library,
i.e. 0.28.x; that version is available in experimental as of this
writing.

There is a proposed patch upstream to fix this [1], and sadly it has
been sitting there for some months now (hdrmerge does not seem an
actively developed project). I extracted the patch/commit from that
upstream PR, and verified that it builds fine with both Exiv2 0.27 and
Exiv2 0.28; you can find it attached to this bug. Would you review this
patch, and upload it so that hdrmerge rebuilds cleanly once a newer
Exiv2 is uploaded to unstable?

[1] https://github.com/jcelaya/hdrmerge/pull/222

Thanks,
-- 
Pino

Author: Lukáš Jirkovský <l.jirkovsky@gmail.com>
Description: Adapt to Exiv2 0.28.0 API change.
Last-Update: 2023-08-03
Forwarded: https://github.com/jcelaya/hdrmerge/pull/222

diff --git a/src/ExifTransfer.cpp b/src/ExifTransfer.cpp
index bc8f4f9..0598172 100644
--- a/src/ExifTransfer.cpp
+++ b/src/ExifTransfer.cpp
@@ -41,7 +41,11 @@ private:
     QString srcFile, dstFile;
     const uint8_t * data;
     size_t dataSize;
+#if EXIV2_TEST_VERSION(0,28,0)
+    Exiv2::Image::UniquePtr src, dst;
+#else
     Exiv2::Image::AutoPtr src, dst;
+#endif
 
     void copyXMP();
     void copyIPTC();
@@ -58,7 +62,11 @@ void hdrmerge::Exif::transfer(const QString & srcFile, const QString & dstFile,
 
 void ExifTransfer::copyMetadata() {
     try {
+#if EXIV2_TEST_VERSION(0,28,0)
+        dst = Exiv2::ImageFactory::open(BasicIo::UniquePtr(new MemIo(data, dataSize)));
+#else
         dst = Exiv2::ImageFactory::open(BasicIo::AutoPtr(new MemIo(data, dataSize)));
+#endif
         dst->readMetadata();
     } catch (Exiv2::Error & e) {
         std::cerr << "Exiv2 error: " << e.what() << std::endl;
diff --git a/src/RawParameters.cpp b/src/RawParameters.cpp
index 40b77de..e6a38eb 100644
--- a/src/RawParameters.cpp
+++ b/src/RawParameters.cpp
@@ -49,7 +49,11 @@ void RawParameters::loadCamXyzFromDng() {
                 cc[j][i] = i == j ? 1.0 : 0.0;
             }
         }
+#if EXIV2_TEST_VERSION(0,28,0)
+        Exiv2::Image::UniquePtr src = Exiv2::ImageFactory::open(fileName.toLocal8Bit().constData());
+#else
         Exiv2::Image::AutoPtr src = Exiv2::ImageFactory::open(fileName.toLocal8Bit().constData());
+#endif
         src->readMetadata();
         const Exiv2::ExifData & srcExif = src->exifData();
 
-- 
2.43.0

--- End Message ---
--- Begin Message --- 
Source: hdrmerge
Source-Version: 0.5+git20200117-4.1
Done: Pino Toscano <pino@debian.org>

We believe that the bug you reported is fixed in the latest version of
hdrmerge, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1071027@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pino Toscano <pino@debian.org> (supplier of updated hdrmerge package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 03 Sep 2024 07:22:48 +0200
Source: hdrmerge
Architecture: source
Version: 0.5+git20200117-4.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Pino Toscano <pino@debian.org>
Closes: 1071027
Changes:
 hdrmerge (0.5+git20200117-4.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Backport upstream commit 377d8e6f3c7cdd1a45b63bce2493ad177dde03fb to make
     hdrmerge compatible with Exiv2 0.28+; patch
     0001-Adapt-to-Exiv2-0.28.0-API-change.patch (Closes: #1071027)
Checksums-Sha1:
 83af369f4700e24a1c517185fcf32856f3a14978 2073 hdrmerge_0.5+git20200117-4.1.dsc
 161f63a1a7e342b0015d33264c6b448ba4cbc57d 5084 hdrmerge_0.5+git20200117-4.1.debian.tar.xz
 75b5eb29521386567a82e544eeb721d71ced6318 11454 hdrmerge_0.5+git20200117-4.1_source.buildinfo
Checksums-Sha256:
 b0265c3a5bd1defb8d01f3fb24b6ebc99b60f96dfad56726c2dc69e3ba73024d 2073 hdrmerge_0.5+git20200117-4.1.dsc
 0e36648c3ab51d3e0b63fdb616878ef476364e2405fcb267913fdf7bf7c453ee 5084 hdrmerge_0.5+git20200117-4.1.debian.tar.xz
 4a9bff0b8c98c474de9512a9f9c80ca96b7177559fb0613730877a312ed4cd62 11454 hdrmerge_0.5+git20200117-4.1_source.buildinfo
Files:
 46e0fc4a96c04e91836db9e704331ad5 2073 graphics optional hdrmerge_0.5+git20200117-4.1.dsc
 664f7ce661f9b7a31ed12f1e26d3fb86 5084 graphics optional hdrmerge_0.5+git20200117-4.1.debian.tar.xz
 9047b0e1b854911f2303ba990b87ae4f 11454 graphics optional hdrmerge_0.5+git20200117-4.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXyqfuC+mweEHcAcHLRkciEOxP00FAmbWnVcACgkQLRkciEOx
P03Wfg/+O+g++M9/FNOIACPwg5kShwimx7SQBzEaBFC8sMhf/5P1oIyF7AC+iLtY
62Oa/PwW6LP+5aqkwME+v6mP1yyxj/c06FKOQFBrQTHzl1iPGcuF65ZoAXNxom6w
kuyXH6XRsAzBQZMTTahU4hA9qLfiKtYDem75a1dqXS+xFka93+njz+i1bqi2UnM9
C6iTxsDasDOrbYgOiq6H2AJlaq/WvrpQm99QK6XhrqGiC6wvLrJeERLMfB8i07hp
KSPW9s0aq92ZvqE0XINK9L2+9KN5subM63TbsNSE5Vw6EaScpoTPsPpOfWXGszuM
DJo68ufgTxhkhjTJ7kx1sE2wOoHfDTPXhRcKO2CoeBI4uy9R94qZ7SpXqO8ouojA
aVOcrXv6FGk8Kwti7gSKUtRM4vugr+hE1Y3LvD3dSyU2qMQiZHIJUkwIHAIKcW8S
rWBJPsM2FTZladfxb+BNBD/6oSu4FrTP39aPiJ2wcJGELLfVByCzB2vDaDm5P7US
zeOLKCGHijoB+RbTpf0T8MSOUUoaAyp96Cf2awxXGVB0ic0bAGKUPPXVXJfBrF7e
kEeXWv0OuwQ+nlB/VMwuFYid46I0wy7+dsvtQ/yD8pgQK4a46mJM+bcIXu8+jnk0
GIX/Bhd6+lgwXlcM7BkKnJFPRyrElQbz8sT2XX3i0/mWzv6Auqo=
=Qc/2
-----END PGP SIGNATURE-----

Attachment: pgpEGIKYUznK7.pgp
Description: PGP signature


--- End Message ---
Reply to: