[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: kodi_21.1~git20240809.ec4eb19+dfsg-1_amd64.changes REJECTED



Hi Thorsten,

>is there a reason why you created dozens of small language packages?

It is <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042996> and the patch
should have made appearance in 21.0 but it caused a REJECTED 5 months ago in
combination with my DM status.

I probably should have mentioned that bug closure in changelog explaining the
reland. Will do!

> Please also mention debian/dh-addon in your debian/coypright.
> As your description mentions the translators, please also acknowledge their work and add them to your debian/copyright as well (at least the Kodi Translation Team).

Will double-check on that now, thanks!

(I recall I *did* mention Translators Team in d/copyright before first ever reject but
somehow it got lost)

>Last but not least the software mixes GPL-2 software (xbmc/cores/VideoPlayer/DVDInputStreams/dvdnav/nav_types.h) with GPL-3+ software (files under tools/EventClients/).
>According to [1] this is not allowed.

Well, I guess since nav_types.h is removed by patch anyway:

<https://salsa.debian.org/multimedia-team/kodi-media-center/kodi/-/blob/debian/experimental/debian/patches/workarounds/0002-xbmc-libdvd_vfs-enen92.patch?ref_type=heads#L3648>

I will just filter GPL-2 files at import-level, re-import source and adjust that patch
so no files are removed twice.

Thanks for the catch-up!

-- 
Vasyl Gello
Certified SolidWorks Expert

E-Mail: vasek.gello@gmail.com
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Reply to: