[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1066836: marked as done (libcamera: ftbfs with 64-bit time_t)

Your message dated Thu, 14 Mar 2024 11:51:35 +0000
with message-id <E1rkjcV-00BlYr-Hn@fasolo.debian.org>
and subject line Bug#1066836: fixed in libcamera 0.2.0-3
has caused the Debian Bug report #1066836,
regarding libcamera: ftbfs with 64-bit time_t
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1066836: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066836
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libcamera
Version: 0.2.0-1
Severity: serious
Tags: patch
Justification: ftbfs
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch

Dear maintainers,

libcamera fails to build from source on 32-bit architectures under 64-bit
time_t, because it has a module that legitimately un-sets _FILE_OFFSET_BITS
for building but this is not allowed without also unsetting _TIME_BITS:

[...]
[267/430] c++ -Isrc/v4l2/v4l2-compat.so.p -Isrc/v4l2 -I../src/v4l2 -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -Wno-redundant-move -Wno-psabi -Wshadow -include /<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf/config.h -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/libcamera-0.2.0-1ubuntu3 -Wno-error -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=3 -fPIC -DLIBCAMERA_BASE_PRIVATE -U_FILE_OFFSET_BITS -D_FILE_OFFSET_BITS=32 -D_LARGEFILE64_SOURCE -fvisibility=hidden -MD -MQ src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -MF src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o.d -o src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -c ../src/v4l2/v4l2_camera.cpp
FAILED: src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o 
c++ -Isrc/v4l2/v4l2-compat.so.p -Isrc/v4l2 -I../src/v4l2 -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -Wno-redundant-move -Wno-psabi -Wshadow -include /<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf/config.h -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/libcamera-0.2.0-1ubuntu3 -Wno-error -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=3 -fPIC -DLIBCAMERA_BASE_PRIVATE -U_FILE_OFFSET_BITS -D_FILE_OFFSET_BITS=32 -D_LARGEFILE64_SOURCE -fvisibility=hidden -MD -MQ src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -MF src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o.d -o src/v4l2/v4l2-compat.so.p/v4l2_camera.cpp.o -c ../src/v4l2/v4l2_camera.cpp
In file included from /usr/include/features.h:394,
                 from /usr/include/arm-linux-gnueabihf/c++/13/bits/os_defines.h:39,
                 from /usr/include/arm-linux-gnueabihf/c++/13/bits/c++config.h:679,
                 from /usr/include/c++/13/bits/requires_hosted.h:31,
                 from /usr/include/c++/13/deque:60,
                 from ../src/v4l2/v4l2_camera.h:10,
                 from ../src/v4l2/v4l2_camera.cpp:8:
/usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
   26 | #   error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
      |     ^~~~~
[...]

  (https://launchpad.net/ubuntu/+source/libcamera/0.2.0-1ubuntu3/+build/27902670)

Since this is a legitimate un-setting of _FILE_OFFSET_BITS in order to get
access to the necessary libc6 prototypes and macros, and since the functions
being intercepted are not sensitive to time_t, the simplest solution is to
also unset _TIME_BITS.

Please see the attached patch, which has been uploaded to Ubuntu to fix this
build failure.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

diff -Nru libcamera-0.2.0/debian/control libcamera-0.2.0/debian/control
--- libcamera-0.2.0/debian/control	2024-01-17 13:27:50.000000000 -0800
+++ libcamera-0.2.0/debian/control	2024-03-13 22:27:39.000000000 -0700
@@ -1,7 +1,6 @@
 Source: libcamera
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
+Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
 Uploaders: Emmanuel Arias <emmanuelarias30@gmail.com>,
            IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>,
            Andrej Shadura <andrewsh@debian.org>,
diff -Nru libcamera-0.2.0/debian/patches/64-bit-time-t-compat.patch libcamera-0.2.0/debian/patches/64-bit-time-t-compat.patch
--- libcamera-0.2.0/debian/patches/64-bit-time-t-compat.patch	1969-12-31 16:00:00.000000000 -0800
+++ libcamera-0.2.0/debian/patches/64-bit-time-t-compat.patch	2024-03-13 22:27:33.000000000 -0700
@@ -0,0 +1,21 @@
+Description: 64-bit time_t compatibility for v4l2 module
+ The v4l2 build unsets _FILE_OFFSET_BITS, which is not allowed when setting
+ _TIME_BITS=64.  Having verified that nothing in this module is sensitive to
+ 64-bit time_t (none of the functions it intercepts handle time), we also
+ unset _TIME_BITS to allow this to build as before.
+Author: Steve Langasek <steve.langasek@canonical.com>
+Forwarded: no
+Last-Update: 2024-03-13
+
+Index: libcamera-0.2.0/src/v4l2/meson.build
+===================================================================
+--- libcamera-0.2.0.orig/src/v4l2/meson.build
++++ libcamera-0.2.0/src/v4l2/meson.build
+@@ -23,6 +23,7 @@
+     # file operations, disable transparent large file support.
+     '-U_FILE_OFFSET_BITS',
+     '-D_FILE_OFFSET_BITS=32',
++    '-U_TIME_BITS',
+     '-D_LARGEFILE64_SOURCE',
+     '-fvisibility=hidden',
+ ]
diff -Nru libcamera-0.2.0/debian/patches/series libcamera-0.2.0/debian/patches/series
--- libcamera-0.2.0/debian/patches/series	2024-01-17 13:27:50.000000000 -0800
+++ libcamera-0.2.0/debian/patches/series	2024-03-13 22:25:15.000000000 -0700
@@ -1,2 +1,3 @@
 ppc64el-fix-ftbfs-gcc.patch
 skip_failing_tests.patch
+64-bit-time-t-compat.patch

--- End Message ---
--- Begin Message --- 
Source: libcamera
Source-Version: 0.2.0-3
Done: Dylan Aïssi <daissi@debian.org>

We believe that the bug you reported is fixed in the latest version of
libcamera, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066836@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <daissi@debian.org> (supplier of updated libcamera package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 14 Mar 2024 11:58:17 +0100
Source: libcamera
Architecture: source
Version: 0.2.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dylan Aïssi <daissi@debian.org>
Closes: 1066836
Changes:
 libcamera (0.2.0-3) unstable; urgency=medium
 .
   [ Jeremy Bícha ]
   * Update debian/gbp.conf
   * Don't use liblltng-ust-dev on i386
   * Disable v4l2 on non-Linux
   * autopkgtest: Run the upstream tests
 .
   [ Steve Langasek ]
   * Add patch for 64-bit time_t compatibility (Closes: #1066836)
 .
   [ Dylan Aïssi ]
   * Refresh patches
   * Drop 'Multi-Arch: same' for libcamera-dev due to file conflict
Checksums-Sha1:
 77512cb6022ab374f045faa9402f1c3d35aded5e 3369 libcamera_0.2.0-3.dsc
 b0e42c7a3c2f7f24a971f80d3e7183e564faf8a9 20168 libcamera_0.2.0-3.debian.tar.xz
 505f47e1a708eafe93f9fe3405f74bb20774ad27 23484 libcamera_0.2.0-3_amd64.buildinfo
Checksums-Sha256:
 0460805c22c564110a4272302b1753c8e1947b8e3402c554e9402eb71b6820b6 3369 libcamera_0.2.0-3.dsc
 03672f1a090692c6806d8a4f32b2920529d7372f7e05d80adafcec6a4f7f9d4b 20168 libcamera_0.2.0-3.debian.tar.xz
 9e03738adaa9f6da8825853216d9b6ab215b3ba31d32e8fd7ba578ce4fa82954 23484 libcamera_0.2.0-3_amd64.buildinfo
Files:
 fa19bcb1e861f8a9120c6ff205ea8e0d 3369 libs optional libcamera_0.2.0-3.dsc
 789ecebc002eb434b331200e4cfbeaaa 20168 libs optional libcamera_0.2.0-3.debian.tar.xz
 8b7ddb1fa3084b7d1485b4886e338e91 23484 libs optional libcamera_0.2.0-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmXy3yEACgkQYS7xYT4F
D1RmaQ//RM8rAVLwhFQwBj/xRJcBXSjqQwmxiwiqmPd0p1C42hahNFwUbRgGt2Xg
uMBiEmsjHKXwngQpdWznXi27y92ICvHduS63sWIO8ysTaZGcaxrMh/0NwSJ7TDfK
sQpbnMdFWukSvpqTihXZucdWEiY0FnEqR8A3jS7mFOZZkK9HYhYweYMwn8aHK2Fc
IFg3g6bp0JWKnkqnT4P9haOooZ2qDe7Vw7C7RktKGhpzJzQo6VsHLnVEh6Vb15xo
7gxszAW461IEoBzN2o0Ibw9TzPblYmKKOITsdgODbgAx/lGmgiDmzGqqhNaPm956
fajoz0bpzwvV5P5X4nQ7M0aKFR7h6dIbUxdpRYFZo4znG0eOOvU9cyYLkD2d1+lY
Tl9VQAD3w9j45E36oRrrPIz9v+pLws7ig+L+mRjiIx7l5xOhHyTs7s4SCUgusSFO
bc5vmoE40LGE1Vj8bNBpTGthvU8VHL64FfGwoYhDB/TIkYe6hH2sPY6MizLT9kbb
z6yuCa3Y0bc4cG5vjTTYc0zqYwM/HIXhbVJU2ZM0YH8YEgoAcGjG9MFxJOWdMIk3
zZfg/ImY3rVUi/6ycIrSt2LD4kAcsSUoh7vGeQ+oVzuIHvm1Bq6Zu4U/NTCQ/ATb
3hnsZBFNcODzs568nF1IYWcZr0wWcF6HlWJtaa+NNhSOa5AasBs=
=nb33
-----END PGP SIGNATURE-----

Attachment: pgpKskfBcCU11.pgp
Description: PGP signature


--- End Message ---
Reply to: