[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1036219: marked as done (Build tests are currently disabled)

Your message dated Mon, 20 Nov 2023 22:49:22 +0000
with message-id <E1r5D50-00Bi7o-3o@fasolo.debian.org>
and subject line Bug#1036219: fixed in libmysofa 1.3.2+dfsg-1
has caused the Debian Bug report #1036219,
regarding Build tests are currently disabled
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1036219: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036219
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libmysofa
Version: 1.3.1~dfsg0-1
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu mantic ubuntu-patch
The build tests are currently disabled and have been since the package was added but they seem to work correctly nowadays (tested in a Debian container and on Ubuntu builders[1]). The attached patch enable those 

Cheers,
Sébastien

[1] https://launchpad.net/ubuntu/+source/libmysofa/1.3.1~dfsg0-1ubuntu1


diff -Nru libmysofa-1.3.1~dfsg0/debian/changelog libmysofa-1.3.1~dfsg0/debian/changelog
--- libmysofa-1.3.1~dfsg0/debian/changelog	2022-10-15 22:04:48.000000000 +0200
+++ libmysofa-1.3.1~dfsg0/debian/changelog	2023-05-17 11:36:35.000000000 +0200
@@ -1,3 +1,13 @@
+libmysofa (1.3.1~dfsg0-2) UNRELEASED; urgency=medium
+
+  * debian/control, debian/rules:
+    - enable build tests
+  * debian/patches/debian_ignore_tests.patch:
+    - ignore tests that require .sofa files which are excluded from the dfsg
+      tarball.
+
+ -- Sebastien Bacher <seb128@ubuntu.com>  Wed, 17 May 2023 11:36:35 +0200
+
 libmysofa (1.3.1~dfsg0-1) unstable; urgency=medium
 
   * New upstream version 1.3.1~dfsg0
diff -Nru libmysofa-1.3.1~dfsg0/debian/control libmysofa-1.3.1~dfsg0/debian/control
--- libmysofa-1.3.1~dfsg0/debian/control	2022-10-15 22:04:48.000000000 +0200
+++ libmysofa-1.3.1~dfsg0/debian/control	2023-05-17 11:36:35.000000000 +0200
@@ -1,12 +1,14 @@
 Source: libmysofa
 Priority: optional
-Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
+XSBC-Original-Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
 Uploaders:
  IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>,
 Build-Depends:
  cmake,
  debhelper-compat (= 13),
  libcunit1-dev,
+ nodejs <!nocheck>,
  zlib1g-dev | libz-dev,
 Standards-Version: 4.6.1
 Rules-Requires-Root: no
diff -Nru libmysofa-1.3.1~dfsg0/debian/patches/series libmysofa-1.3.1~dfsg0/debian/patches/series
--- libmysofa-1.3.1~dfsg0/debian/patches/series	2022-10-15 22:04:48.000000000 +0200
+++ libmysofa-1.3.1~dfsg0/debian/patches/series	2023-05-17 11:36:35.000000000 +0200
@@ -1 +1,2 @@
 dynamically-link-tools.patch
+debian_ignore_tests.patch
diff -Nru libmysofa-1.3.1~dfsg0/debian/patches/debian_ignore_tests.patch libmysofa-1.3.1~dfsg0/debian/patches/debian_ignore_tests.patch
--- libmysofa-1.3.1~dfsg0/debian/patches/debian_ignore_tests.patch	1970-01-01 01:00:00.000000000 +0100
+++ libmysofa-1.3.1~dfsg0/debian/patches/debian_ignore_tests.patch	2023-05-17 11:36:35.000000000 +0200
@@ -0,0 +1,27 @@
+# Description: ignore tests which depend on non dfsg files that Debian
+# is removing from the tarball
+# Upstream: not-needed
+Index: libmysofa-1.3.1~dfsg0/CMakeLists.txt
+===================================================================
+--- libmysofa-1.3.1~dfsg0.orig/CMakeLists.txt	2022-10-04 18:31:49.000000000 +0200
++++ libmysofa-1.3.1~dfsg0/CMakeLists.txt	2023-05-17 15:38:45.843397388 +0200
+@@ -57,8 +57,6 @@
+            ${PROJECT_SOURCE_DIR}/tests/Mesh2HRTF.sofa)
+   add_test(D1_48K_24bit_0.3s_FIR_SOFA src/mysofa2json
+            ${PROJECT_SOURCE_DIR}/tests/D1_48K_24bit_0.3s_FIR_SOFA.sofa)
+-  add_test(H20_44K_16bit_256tap_FIR_SOFA ${PROJECT_SOURCE_DIR}/tests/compareIgnoreNew.sh
+-           ${PROJECT_SOURCE_DIR}/tests/H20_44K_16bit_256tap_FIR_SOFA)
+   add_test(MIT_KEMAR_large_pinna ${PROJECT_SOURCE_DIR}/tests/compare.sh
+            ${PROJECT_SOURCE_DIR}/tests/MIT_KEMAR_large_pinna)
+   add_test(MIT_KEMAR_normal_pinna ${PROJECT_SOURCE_DIR}/tests/compareIgnoreNew.sh
+@@ -104,10 +102,6 @@
+            ${PROJECT_SOURCE_DIR}/tests/LISTEN_1002_IRC_1002_C_HRIR)
+   add_test(Pulse ${PROJECT_SOURCE_DIR}/tests/compare.sh ${PROJECT_SOURCE_DIR}/tests/Pulse)
+   add_test(Tester ${PROJECT_SOURCE_DIR}/tests/compare.sh ${PROJECT_SOURCE_DIR}/tests/tester)
+-  add_test(TU-Berlin_QU_KEMAR_anechoic_radius_0.5_1_2_3_m ${PROJECT_SOURCE_DIR}/tests/compare.sh
+-           ${PROJECT_SOURCE_DIR}/tests/TU-Berlin_QU_KEMAR_anechoic_radius_0.5_1_2_3_m)
+-  add_test(TU-Berlin_QU_KEMAR_anechoic_radius_0.5m ${PROJECT_SOURCE_DIR}/tests/compare.sh
+-           ${PROJECT_SOURCE_DIR}/tests/TU-Berlin_QU_KEMAR_anechoic_radius_0.5m)
+   add_test(example_dummy_sofa48 ${PROJECT_SOURCE_DIR}/tests/compare.sh
+            ${PROJECT_SOURCE_DIR}/tests/example_dummy_sofa48)
+   add_test(TestSOFA48_netcdf472 ${PROJECT_SOURCE_DIR}/tests/compare.sh
diff -Nru libmysofa-1.3.1~dfsg0/debian/rules libmysofa-1.3.1~dfsg0/debian/rules
--- libmysofa-1.3.1~dfsg0/debian/rules	2022-10-15 22:04:48.000000000 +0200
+++ libmysofa-1.3.1~dfsg0/debian/rules	2023-05-17 11:36:35.000000000 +0200
@@ -13,8 +13,9 @@
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
 
+# the tests have hardcoded reference to build/src
 %:
-	dh $@
+	dh $@ --builddirectory=build
 
 override_dh_auto_configure:
 	dh_auto_configure -- \
@@ -23,9 +24,9 @@
 		-DCODE_COVERAGE=OFF \
 		$(empty)
 
+# no-parallel otherwise we are hitting test errors
 override_dh_auto_test:
-	# tests have been disabled, until we figure out how to make them not stall
-	@echo "skipping tests"
+	dh_auto_test --no-parallel
 
 override_dh_clean:
 	dh_clean

--- End Message ---
--- Begin Message --- 
Source: libmysofa
Source-Version: 1.3.2+dfsg-1
Done: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>

We believe that the bug you reported is fixed in the latest version of
libmysofa, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1036219@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated libmysofa package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 20 Nov 2023 23:22:06 +0100
Source: libmysofa
Architecture: source
Version: 1.3.2+dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Closes: 1036219
Changes:
 libmysofa (1.3.2+dfsg-1) unstable; urgency=medium
 .
   [ IOhannes m zmölnig (Debian/GNU) ]
   * New upstream version 1.3.2+dfsg
     + Refresh patches (with 'gbp pq')
     + Backported upstream patches
   * Ship Cmake snippets in libmysofa-dev
   * Re-enable build tests
     Thanks to Sebastien Bacher <seb128@ubuntu.com> (Closes: #1036219)
   * Update copyright information
     + Update d/copyright
     + Re-generate d/copyright_hints
     + Modernize licensecheck target
   * d/watch: use repacksuffix
   * Bump standards version to 4.6.2
Checksums-Sha1:
 784f96922aea1838b323e7e5379d010d9089709c 2386 libmysofa_1.3.2+dfsg-1.dsc
 d75d77f8e81401d2071e9cc53d8181f2747dfb4a 81123036 libmysofa_1.3.2+dfsg.orig.tar.xz
 864f11129ec35116d75d823bb05a7d1fcf821142 18452 libmysofa_1.3.2+dfsg-1.debian.tar.xz
Checksums-Sha256:
 f685204bc3bff91b0d89c1b04a767622e5a116370929fc26dfbf73c1fc55990e 2386 libmysofa_1.3.2+dfsg-1.dsc
 451593b531ce3b15b3c75c4d9fdef5d2cbb641682c3d702bd6aad5fa7a05488b 81123036 libmysofa_1.3.2+dfsg.orig.tar.xz
 df49cfcaf4eff20c6a4fa6ca73a35f00d62b0245369c08462f902013a66122cf 18452 libmysofa_1.3.2+dfsg-1.debian.tar.xz
Files:
 719148b83035668d3eb78756ed66be46 2386 devel optional libmysofa_1.3.2+dfsg-1.dsc
 4dee7a41dba481479aff11711a28bd2a 81123036 devel optional libmysofa_1.3.2+dfsg.orig.tar.xz
 bf8c1784f4da06c6a74fd3ded16edbeb 18452 devel optional libmysofa_1.3.2+dfsg-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJKBAEBCAA0FiEEdAXnRVdICXNIABVttlAZxH96NvgFAmVb3PwWHGZvcnVtQHVt
bGFldXRlLm11ci5hdAAKCRC2UBnEf3o2+PUAD/9Fwd4BxWQvN/wSn+vghW954FUu
QbBpzPpc8Ihso0tr03ls5der5YwEvsx4YYavTTZ712JFoIiRoUO1DRZETwcszjsw
4lNqa4/HeVrAAg7BgQX/3mMAzJHo6PPf2UF1ALHymfb5DEy73fywyg6VYb9av2GB
iT1o7a5a3w9tPIWnHrXLECNfRVfpUIMrV0jr1VtqyNSrhL82m48I9FBp3n+H/Vz7
wxmEeEuGmuaN9PYAaMizANlZaJdAZu+DRkYxxdRhFlOXV5LTl2c9n9m3eMJ+2PTp
BogggC5zbg7aXQR6Xb8h79vOGZRjPX8GsVx11Xt6lOeOvJ2VaK6LRfXlBEFmSmZH
QcNit+XLy0E6WvKn7ezSnQ4IN0NCN8AuRDfB6WIVocQJtm8pkFK/7N/TuXQgZURg
06M3jsHkcjwDNV7S2SOcDxVg2weidpxPCDvVpCloL6N2p5Gd+5xdsH2/qsk7nqD7
vXWvyEst51CkZauu4cvCj3ZfuEVOMToIlyQkNDboGD2IjPy2JGpjd6de3lcewIIq
Ak1d4RgLexJvdCZ9nFn3lKS06lKiHcmLhwcPMFMMCUCkSYv7rdvtSt+qlZDqANxP
nNz6KYrvMRkAcxvqZJ0VaJdH36vNcInkrjUSoK3a/S1eRt4ANy1v0ZqBozQypk66
tz7UnhWd+KA7p3L0XA==
=887r
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: