[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1051573: marked as done (bambootracker: FTBFS with RtAudio 6)

Your message dated Fri, 22 Sep 2023 09:04:11 +0000
with message-id <E1qjc55-006exk-OK@fasolo.debian.org>
and subject line Bug#1051573: fixed in bambootracker 0.6.3-1
has caused the Debian Bug report #1051573,
regarding bambootracker: FTBFS with RtAudio 6
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1051573: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051573
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: bambootracker
Version: 0.6.1-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

bambootracker ftbfs with RtAudio 6 (currently found in experimental).

```
g++ -c -pipe -g -O2 -ffile-prefix-map=/build/bambootracker-CzYJbF/bambootracker-0.6.1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++1y -pthread -pthread -Wall -Wextra -Wall -Wextra -Werror -pedantic -pedantic-errors -D_REENTRANT -fPIC -DQT_DEPRECATED_WARNINGS -D__LINUX_ALSA__ -D__LINUX_PULSE__ -D__UNIX_JACK__ -D_REENTRANT -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I. -Iinstrument -Imodule -I../submodules/emu2149/src -I/usr/include/rtaudio -I/usr/include/rtmidi -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtWidgets -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o audio_stream_rtaudio.o audio/audio_stream_rtaudio.cpp
audio/audio_stream_rtaudio.cpp: In member function ‘virtual bool AudioStreamRtAudio::initialize(uint32_t, uint32_t, uint32_t, const QString&, const QString&, QString*)’:
audio/audio_stream_rtaudio.cpp:82:16: error: ‘RtAudioError’ does not name a type; did you mean ‘RtAudioErrorType’?
   82 |         catch (RtAudioError& error) {
      |                ^~~~~~~~~~~~
      |                RtAudioErrorType
audio/audio_stream_rtaudio.cpp:83:17: error: ‘error’ was not declared in this scope; did you mean ‘perror’?
   83 |                 error.printMessage();
      |                 ^~~~~
      |                 perror
make: *** [Makefile:4064: audio_stream_rtaudio.o] Error 1
```

Attached is a patch that fixes the FTBFS (but is otherwise untested).
No debdiff this time, sorry.

cheers.

Description: Fix FTBFS with RtAudio6
 Replace try/catch with check for return code
Author: IOhannes m zmölnig
Origin: Debian
Forwarded: no
Last-Update: 2023-09-09
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: bambootracker-0.6.1/BambooTracker/audio/audio_stream_rtaudio.cpp
===================================================================
--- bambootracker-0.6.1.orig/BambooTracker/audio/audio_stream_rtaudio.cpp
+++ bambootracker-0.6.1/BambooTracker/audio/audio_stream_rtaudio.cpp
@@ -73,16 +73,15 @@ bool AudioStreamRtAudio::initialize(uint
 
 	unsigned int bufferSize = rate * duration / 1000;
 	bool isSuccessed = false;
-	try {
-		audio->openStream(&param, nullptr, RTAUDIO_SINT16, rate, &bufferSize, callback, this, &opts);
 		if (errDetail) *errDetail = "";
-		isSuccessed = true;
-		rate = audio->getStreamSampleRate();	// Match to real rate (for ALSA)
-	}
-	catch (RtAudioError& error) {
-		error.printMessage();
-		if (errDetail) *errDetail = QString::fromStdString(error.getMessage());
-	}
+		if (audio->openStream(&param, nullptr, RTAUDIO_SINT16, rate, &bufferSize, callback, this, &opts)) {
+			std::string err = audio->getErrorText();
+			std::cerr << err << std::endl;
+			if (errDetail) *errDetail = QString::fromStdString(err);
+		} else {
+		    isSuccessed = true;
+		    rate = audio->getStreamSampleRate();	// Match to real rate (for ALSA)
+		}
 
 	AudioStream::initialize(rate, duration, intrRate, backend, device);
 	return isSuccessed;

--- End Message ---
--- Begin Message --- 
Source: bambootracker
Source-Version: 0.6.3-1
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
bambootracker, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1051573@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated bambootracker package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 22 Sep 2023 09:44:04 +0200
Source: bambootracker
Architecture: source
Version: 0.6.3-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 1044108 1051573
Changes:
 bambootracker (0.6.3-1) experimental; urgency=medium
 .
   * New upstream version 0.6.3
     + Build with RtAudio 6 (Closes: #1051573)
   * Remove obsolete patch
   * Clean modified files after successful build (Closes: #1044108)
Checksums-Sha1:
 f010c359d159bb6f92555740cdbfc73d66143c47 2223 bambootracker_0.6.3-1.dsc
 2373ecbbeaddfbde0e91501ea7cb981910977cd4 1088065 bambootracker_0.6.3.orig.tar.gz
 e57c90857996d438eb0f73faf320335cfbc8eb06 12388 bambootracker_0.6.3-1.debian.tar.xz
 a67dfa925b066abd29ceb9da70f74bdd4a884684 5897 bambootracker_0.6.3-1_source.buildinfo
Checksums-Sha256:
 d17f8dd832cde2b223e51869033a4c76c89661888760d5eeb8fdb75ca92a75f2 2223 bambootracker_0.6.3-1.dsc
 fcef1cba18c32c6ff6ad813186f366fe74ff9267966004f320155fba4a666da0 1088065 bambootracker_0.6.3.orig.tar.gz
 1a46f6cfdbd5eaaba047298e1de69831670adc8308513b82edf58299ef3445b9 12388 bambootracker_0.6.3-1.debian.tar.xz
 a69dcb328175753f2d4b32a3f101d3f296152b4931825cd0bd3e22c4ccbb0794 5897 bambootracker_0.6.3-1_source.buildinfo
Files:
 437b1c2903ec357f5f9118da4ab492d2 2223 sound optional bambootracker_0.6.3-1.dsc
 4e527717f4591033cafab083b834d0ab 1088065 sound optional bambootracker_0.6.3.orig.tar.gz
 0bb4485cddf4eaf849e07bcab92d1eb4 12388 sound optional bambootracker_0.6.3-1.debian.tar.xz
 48a84d42566e431b6386c8fd3f1179a1 5897 sound optional bambootracker_0.6.3-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmUNRk8PHHNuZEBkZWJp
YW4ub3JnAAoJEGNOpV2QK5g2NC8QAKRHCCMuPgm6DKpYQmDKgmUxWm8jbddYWucn
Ae8IfmDBJ9NqUev69DrvCERN1KVN8p59Pm3+surNCRDc2zs17ab8u2cUGIHRJ7ea
kgQ+E4+HnAUXpdfw+SEtkRkUJdv+gTbHaRX8DztGqCLBksrbIoTxfCBbyyQJF2gA
mpkSyj0waY48Mx9j1vLs1TECrlo/uZdPAujlqaqnAC1HG5bf+8r8XzeVIeCTLJ+L
8xiDtNX8QkInMgY9x78MHWPgtD+bHHzmmhdpjbMcDzWefNRrDm9rOw7aPS6gvcha
w831dBa3vnjE72uKQ/Px/e+m/8vyDdAGsB69LquEI1Dsi4JYowQRAYkVgLd2w5dh
ZJ6PgEFY8INzKR56w1GmNspKWzRCKJs65dl1xPtMf22yMiQvCnLa8BG9YWJskHSZ
eGBbOTjgANqqNGTcjC59mOPjAPn+l8myWBd0w4P2Agk0t0SPtdY8bddfO32NV+EV
UwQc5PXvyxXjq4GqyxFTPzOArj1UpR3XDPNG5JeumlGi5xuckDhDE/ncvZbnQ2An
Ud5VrCbaPJRgKdWgDbR+/bDOW1D/oCH9irG3/4Drv1tQ9sKuaz+UPLCfCbIXQFT3
8yk7tW7DwmJfYM97QC9/MGlrwA0/lYbtfPYh56pZm/qfK83HLP+ThPVIkPR6k4I8
uvtqAybO
=NVVN
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: