Re: [feature request[ Merge SOUNDTOUCH_NO_CONFIG patch

[Nicolas George <george@nsup.org>]

jsupertoot@dnmx.org (12023-03-23):
> I didn't know the same user made a pr upstream, too. I still think it
> would be nice to have the option to disable it, but I guess I'll just have
> to work around it.

If I understand the issue correctly, you have a libsomething that ships
with something_config.h, and you want applied a patch that lets programs
including something_config.h indirectly define a preprocessor constant
to disable its contents because they do not match your need.

Is that it?

If so, then I see two flaws in this intent:

1. You do not need a patch for that, just put an empty
something_config.h in a directory earlier in the search path, plus
possibly symplinks to the headers that include it if they include it
"..." rather than <...>.

2. Anyway, something_config.h is supposed to describe how the
libsomething.so you has has been built. If you compile your project with
a different version of something_config.h, the result will not be
ABI-compatible with the libsomething.so you have, resulting in crashes.

If the point 2 does not apply, that means a more subtle bug exists in
libsomething, and this patch is roughly equivalent to asking to leave
the window open because the door lock is broken.

Regards,

-- 
  Nicolas George