[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#968641: marked as done (jack-audio-connection-kit: included Makefile embeds variable information)

Your message dated Fri, 06 Jan 2023 22:34:30 +0000
with message-id <E1pDvIE-00FUEi-SK@fasolo.debian.org>
and subject line Bug#968641: fixed in jack-audio-connection-kit 1:0.126.0-2
has caused the Debian Bug report #968641,
regarding jack-audio-connection-kit: included Makefile embeds variable information
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
968641: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968641
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: jack-audio-connection-kit
Severity: normal
Version: 1:0.125.0-3
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The generated Makefile shipped in jackd1 includes the build path of the
build, various embedded paths for SHELL, SED, GREP, etc. which may
differ if built on a usrmerged system.

This Makefile is arguably broken, containing paths which may not be
present on the user's system. Since the user would have to re-generate
this file in order to use it anyways, the simplest thing to do is not
install the file at all.

The attached patch removes this file in debian/rules with a
dh_installexamples override.


Thanks for maintaining jack-audio-connection-kit!


live well,
  vagrant

From 205403909ee8e0349823fb91fcc95b2ebab473eb Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 18 Aug 2020 21:34:56 +0000
Subject: [PATCH] debian/rules: Add dh_installexamples override to remove
 generated Makefile which breaks reproducible builds.

---
 debian/rules | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/debian/rules b/debian/rules
index 320470f..fb1db40 100755
--- a/debian/rules
+++ b/debian/rules
@@ -35,6 +35,14 @@ endif
 override_dh_auto_configure:
 	dh_auto_configure -- $(DEB_CONFIGURE_EXTRA_FLAGS)
 
+override_dh_installexamples:
+	dh_installexamples
+	# Remove generated Makefile which contains build paths and
+	# hard-coded paths to binaries, which need to be regenerated
+	# in order to be used. Removing it also fixes Reproducible
+	# Builds.
+	rm -f debian/jackd1/usr/share/doc/jackd1/examples/python/Makefile
+
 # this target fetches the FAQ from the JACK homepage
 .PHONY: faq
 faq:
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: jack-audio-connection-kit
Source-Version: 1:0.126.0-2
Done: Dennis Braun <snd@debian.org>

We believe that the bug you reported is fixed in the latest version of
jack-audio-connection-kit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 968641@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dennis Braun <snd@debian.org> (supplier of updated jack-audio-connection-kit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 06 Jan 2023 23:02:48 +0100
Source: jack-audio-connection-kit
Architecture: source
Version: 1:0.126.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Dennis Braun <snd@debian.org>
Closes: 968641
Changes:
 jack-audio-connection-kit (1:0.126.0-2) unstable; urgency=medium
 .
   * Team upload
 .
   [ Dennis Braun ]
   * Some example files are still left. Remove the Makefile.
     Thanks to Vagrant Cascadian! (Closes: #968641)
 .
   [ IOhannes m zmölnig (Debian/GNU) ]
   * Use dh-sequence-bash-completion via B-Ds
   * Let dh auto-detect the buildsystem
   * Use execute_after_dh_* rather than override_dh_* whenever possible
 .
   [ Debian Janitor ]
   * Apply multi-arch hints. + libjack-dev: Add Multi-Arch: same.
 .
   [ Dennis Braun ]
   * Format spelling error patch with gbp pq
   * Bump Standards-Version to 4.6.2
Checksums-Sha1:
 e464e0f64cebc72c3bb3f2ca965918d3a10cb87f 2712 jack-audio-connection-kit_0.126.0-2.dsc
 7becbf28784d4a7f3de63b6ece2c217a8bc1b5a4 33524 jack-audio-connection-kit_0.126.0-2.debian.tar.xz
 a868e27f8da70dd7683d68e2d66b307e6e87679d 6380 jack-audio-connection-kit_0.126.0-2_source.buildinfo
Checksums-Sha256:
 187fed2da5afffb3cee09734cd0db82dd4a585e413e6ce4a7b01f6a62d4f93ab 2712 jack-audio-connection-kit_0.126.0-2.dsc
 230f2558a787d423b596e15a172872e5d798f05f4338dbbad593f5fdb69ae63c 33524 jack-audio-connection-kit_0.126.0-2.debian.tar.xz
 85e377bab5a69c58c8b87995bceabb38e508f8068f565c41d93fef17546f8b16 6380 jack-audio-connection-kit_0.126.0-2_source.buildinfo
Files:
 2e7cbaaa1f51d80d6112e231ca934c89 2712 sound optional jack-audio-connection-kit_0.126.0-2.dsc
 3c019a47f70983e009e481db6b479d06 33524 sound optional jack-audio-connection-kit_0.126.0-2.debian.tar.xz
 620bce403b5c99bca8db319df846636f 6380 sound optional jack-audio-connection-kit_0.126.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEPLfDAq+1fmGoxhfdY06lXZArmDYFAmO4nLcPHHNuZEBkZWJp
YW4ub3JnAAoJEGNOpV2QK5g2MJ0P/Arf0cHMOWe7GaOa678eT8KNPgzRaw3KCV5C
Eg8EARulImepRYOq5MMzB40DKJitJ2XUrfdO0yhljIl3OFy9gZ4e3Q1XdwdPNSBA
7loHc+CcV/NOM25CvLIdFqulPP72Ncd3hH2jECBqljan7mabBmOX2/jGtOh+bXUy
qejRkFmrvudRT5pSHKGklJhX0Tk3osPjRcugmfsnS4dDJn6fnyuL5ximNr/Vtk7y
FGnZitj6jt7WCbSkKt8yolipcAJC7CqtCrVfVzf21G3t23KBZDfh4IBHTcpbV/0R
tw7QWUCA2hItst3QQ3PHSp2oXPHwMULJK23q7y7gye3HrqN5X3Mm7Qse92uAJWOC
bAnkW5lV80u9v3YDHrPO4+LkxCXyQ/pVlMD42Jkq0e1Zkl16Ku+Pysa2G6xQkOu3
Wxl0ixr6Nv1hicnSZFXwegkFrYfWSuvIXn3zNgOXGydsNTvAWzW1zzm956+RKRuw
kDc+s4/2VnPcd4vmrZgxMbgLTF6Eoy+6XCXWbXar7382JE+MZVrcStCOSGWAT1CX
/IaoX3l0O2ofUPeYVvNqB7Je7MEMRriyqDT2s9oJqDk57ZSjUO6hOlpugD+3Jd++
5viHzc1aaH4I7AXbkwktv0S/8tz2jX29HrQJJ7BDSB3umc+7KY2fg+pVN4P7Zvhe
Nnoemz5E
=wugt
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: